fix(logger): preserve percent-style formatting args in flush_buffer#8009
Merged
leandrodamascena merged 2 commits intodevelopfrom Feb 27, 2026
Merged
Conversation
- Fix _create_and_flush_log_record to use stored args from buffer - Add test for percent-style formatting in buffered logs - Resolves issue where format strings were not interpolated on flush Fixes #8005
pull-request-size
bot
added
the
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8009 +/- ##
========================================
Coverage 96.73% 96.73%
========================================
Files 278 278
Lines 13654 13657 +3
Branches 1086 1086
========================================
+ Hits 13208 13211 +3
Misses 327 327
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dreamorosi
changed the title
leandrodamascena
approved these changes
Feb 27, 2026
Contributor
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Welcome as a new Python contributor @dreamorosi 😄!
Thanks for working on this, man! APPROVED.
|
leandrodamascena
deleted the
fix/flush-buffer-percent-style-formatting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8005
Summary
Changes
Fixed
_create_and_flush_log_recordmethod to preserve percent-style formatting arguments when flushing buffered log records. Changed hardcodedargs=()toargs=log_line.get("args", ())to use the arguments stored in the buffer.User experience
Before: Buffered logs with percent-style formatting (e.g.,
logger.debug("user=%s count=%d", "alice", 42)) would flush as literal format strings:"user=%s count=%d"After: Buffered logs are properly interpolated when flushed:
"user=alice count=42"By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.