Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a typing issue in the cachebox.cached decorator to properly support callable cache providers when used with instance methods. The cached function already supported callable cache providers in its implementation (allowing patterns like @cachebox.cached(lambda self: self._cache)), but the type hint was missing this option, causing type checkers to report errors.
Changes:
- Updated the type hint for the
cacheparameter in thecachedfunction to includetyping.Callable[..., BaseCacheImpl]in the union type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes typing issue
cachebox.cachedapplied on an instance method: