Skip to content

Fix Genesis 17 verse count to 27 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avendesora merged 3 commits into from
Dec 30, 2025
Merged

Fix Genesis 17 verse count to 27 #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15003f2
test: add failing test for number of verses in Genesis 17
jirehhuang Dec 29, 2025
1401734
fix: update verse count in Genesis 17 from 28 to 27
jirehhuang Dec 29, 2025
06c57e0
fix(test): fix type checking for count_verses(str)
jirehhuang Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pythonbible/verses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
24,
21,
16,
28,
27,
34,
38,
19,
Expand Down
11 changes: 11 additions & 0 deletions tests/counters_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,14 @@ def test_count_verses_string() -> None:

# Then the count is correct
assert number_of_verses == 1 + 1 + (3 + 1)


def test_count_verses_genesis_17() -> None:
# To address https://github.com/avendesora/pythonbible/issues/223
reference: str = "Genesis 17"

# Retrieve number of verses in Genesis 17
number_of_verses: int = bible.count_verses(reference) # type: ignore[arg-type]

# Genesis 17 should have 27 verses
assert number_of_verses == 27
Loading