-
Notifications
You must be signed in to change notification settings - Fork 17
Update supported Python versions #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR standardizes the project’s supported Python versions by dropping 3.8 and adding 3.14 throughout the codebase, updates the release metadata, and tweaks the test runner configuration. Flow diagram for updated test session Python versions in Noxflowchart TD
NoxSession[Nox test session]
NoxSession -->|Runs tests on| Python39[Python 3.9]
NoxSession -->|Runs tests on| Python310[Python 3.10]
NoxSession -->|Runs tests on| Python311[Python 3.11]
NoxSession -->|Runs tests on| Python312[Python 3.12]
NoxSession -->|Runs tests on| Python313[Python 3.13]
NoxSession -->|Runs tests on| Python314[Python 3.14]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @avendesora - I've reviewed your changes - here's some feedback:
- The installation guide in docs/source/installation.rst still lists the old Python support and should be updated to match the new >=3.9 requirement.
- Make sure the project version in pyproject.toml (under tool.flit.metadata) is bumped to match the new release (0.13.1).
- Consider running the coverage session on the minimum supported Python version (3.9) instead of only on 3.13 to catch compatibility issues early.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The installation guide in docs/source/installation.rst still lists the old Python support and should be updated to match the new >=3.9 requirement.
- Make sure the project version in pyproject.toml (under tool.flit.metadata) is bumped to match the new release (0.13.1).
- Consider running the coverage session on the minimum supported Python version (3.9) instead of only on 3.13 to catch compatibility issues early.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Description
Please include a summary of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
Summary by Sourcery
Update project to drop Python 3.8 support and add Python 3.14 support across metadata, CI, configuration, and documentation while bumping the release version to 0.13.1.
Enhancements:
Build:
CI:
Documentation:
Chores: