Draft
Conversation
allowInterop can be used multiple times on the same function without adverse effects, so it is ok if the user also passes a function that has already been "interoped"
CONFLICT (content): Merge conflict in: - auth0_flutter/lib/auth0_flutter_web.dart - auth0_flutter/lib/src/web/auth0_flutter_plugin_real.dart - auth0_flutter/lib/src/web/js_interop.dart - auth0_flutter/test/web/auth0_flutter_web_test.mocks.dart - auth0_flutter_platform_interface/lib/src/login_options.dart
Author
|
Stalled on finishing this until #686 is resolved. |
Contributor
|
Hi @trevordunn, Just checking upon this . Are you facing any issues now that #686 is fixed ? |
Author
|
@pmathew92 I'm still seeing #686. Left a comment there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #393, which seems to have gone stale.
📋 Changes
openUrlparameter in bothloginWithRedirectandlogouton the browser version.openUrlrequires auth0-spa-js version2.0.1or later.This is important to me due to the @microsoft/teams-js library necessary to do authentication inside microsoft teams, reference docs here
In short, it handles authentication in its own window.
My use case would be something similar to
🎯 Testing
2.0to2.0.1atauth0_flutter/example/web/index.htmlloginWithRedirectandlogoutfunctionsPossible concerns
While manual testing, you will also see two errors in the web console:
Error: Promise was rejected with a value of 'undefined'TypeError: T.as is not a functionFrom my tests, this seems be comming out of the main
auth0-spa-jslibrary due to unhandled rejections, and doesn't affect the usage ofauth0_flutteritself. Though it would require a deeper research on why it is happening.