Fix HTTP session inefficiency by sharing MultiIndexRunner across sessions#17
Open
augment-app-staging[bot] wants to merge 1 commit intomainfrom
Open
Fix HTTP session inefficiency by sharing MultiIndexRunner across sessions#17augment-app-staging[bot] wants to merge 1 commit intomainfrom
augment-app-staging[bot] wants to merge 1 commit intomainfrom
Conversation
…ions Currently, every new HTTP client session creates a fresh MultiIndexRunner instance via createMCPServer(). This causes redundant store.list() and store.loadSearch() calls for every index on every session, which is wasteful especially for S3-backed stores. This change shares a single MultiIndexRunner instance across all HTTP sessions while maintaining per-session MCP Server instances (required by MCP protocol). Changes: - Add optional 'runner' field to MCPServerConfig interface - Update createMCPServer() to use provided runner if available, otherwise create new one - Modify createMCPHttpServer() to create shared runner once and pass to all sessions - Add comments explaining the optimization and updateClientUserAgent behavior The shared MultiIndexRunner is safe because it already has lazy client caching. All existing tests pass and backward compatibility is maintained. Related: https://slack.com/archives/C0ACX5SLML7/p1770850068455299
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently in
src/clients/mcp-http-server.ts, every new HTTP client session creates a fresh MultiIndexRunner instance via createMCPServer(). This causes redundant store.list() + store.loadSearch() calls for every index on every session, which is wasteful especially for S3-backed stores.Solution
Share a single MultiIndexRunner instance across all HTTP sessions while maintaining per-session MCP Server instances (required by MCP protocol).
Changes
Modified
src/clients/mcp-server.ts:runner?: MultiIndexRunnerfield to theMCPServerConfiginterfacecreateMCPServer()function to:config.runneris provided, use it instead of creating a new oneModified
src/clients/mcp-http-server.ts:createMCPHttpServer()function, create a single shared MultiIndexRunner instance during server initialization (before the session handling logic)createMCPServer()call via the configBenefits
Testing
Related
Slack discussion: https://slack.com/archives/C0ACX5SLML7/p1770850068455299