feat(nodeminer): Cache block info to speed up mining #95
Conversation
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block. The `Blockchain::getMineInfo` method has been refactored to use a cache, and the `NodeMiner` has been updated to check for new blocks more frequently.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
include/class/NodeMiner.php
Outdated
| break; | ||
| } | ||
| $info = $this->getMiningInfo(); | ||
| if($info!==false) { |
There was a problem hiding this comment.
You are right. Checking on every hash is inefficient due to the overhead of calling getMiningInfo, even with caching. I have updated the logic to check for a new block approximately once per second, based on the miner's hash speed. This should provide a good balance between responsiveness and performance.
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block. The `Blockchain::getMineInfo` method has been refactored to use a cache, and the `NodeMiner` has been updated to check for new blocks more frequently. This commit also addresses the feedback from the code review, ensuring that the miner checks for new blocks at a reasonable rate.
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block. The `Blockchain::getMineInfo` method has been refactored to use a cache, and the `NodeMiner` has been updated to check for new blocks on every hash iteration.
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block. The `Blockchain::getMineInfo` method has been refactored to use a cache, and the `NodeMiner` has been updated to check for new blocks on every hash iteration. This commit also addresses the feedback from the code review, ensuring that the miner checks for new blocks at a reasonable rate, and that the caching logic is robust.
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block. The `Blockchain::getMineInfo` method has been refactored to use a cache, and the `NodeMiner` has been updated to check for new blocks on every hash iteration. The cache is also correctly updated when a new block is added or deleted.
This change introduces caching for block information to improve the performance of the nodeminer. By caching the mining info, the miner can now check for new blocks after every hash, making it much faster to start working on a new block.
PR created automatically by Jules for task 15423832845657900381 started by @attogram