Fix XSS vulnerabilities in user-displayed data #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new `safeDisplay` function to sanitize user input before it is displayed on the page. This function uses `htmlspecialchars` to prevent XSS attacks. Applied the `safeDisplay` function to all identified locations where user-provided data is displayed, including transaction messages and search inputs.
Introduced a new `safeDisplay` function in `apps.functions.php` to sanitize output using `htmlspecialchars`. This change applies the `safeDisplay` function to multiple locations to prevent reflected XSS attacks: - Sanitized the `$_GET['search']` parameter in `apps/explorer/accounts.php`. - Sanitized `$_REQUEST` parameters in `apps/explorer/smart_contract.php`. - Sanitized the `transaction['message']` field where it is displayed in `apps/explorer/address.php`, `tx.php`, and `mempool.php`. - Sanitized smart contract parameters decoded from the transaction message in `apps/explorer/tx.php` before they are displayed.
Introduced a new `safeDisplay` function in `apps.functions.php` to sanitize output using `htmlspecialchars`. This change applies the `safeDisplay` function to multiple locations to prevent reflected XSS attacks: - Sanitized the `$_GET['search']` parameter in `apps/explorer/accounts.php`. - Sanitized `$_REQUEST` parameters in `apps/explorer/smart_contract.php`. - Sanitized the `transaction['message']` field where it is displayed in `apps/explorer/address.php`, `tx.php`, and `mempool.php`. - Sanitized smart contract parameters decoded from the transaction message in `apps/explorer/tx.php` before they are displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes multiple Cross-Site Scripting (XSS) vulnerabilities. A shared
safeDisplayfunction was created to sanitize output usinghtmlspecialchars. This function was then applied to all identified locations where user-provided data, including transaction messages, smart contract parameters, and URL search parameters, is displayed back to the user. This prevents malicious scripts from being executed in the user's browser.PR created automatically by Jules for task 14936323345649994863 started by @attogram