Make homepage apps configurable and improve icon handling #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a `homepage_apps` array to the config file to allow for easy customization of the homepage app blocks. - Refactors the homepage to dynamically generate the app blocks from the configuration. - Includes a fallback to a default set of apps if the configuration is not present. - Removes the use of `eval()` for conditional app display and replaces it with a secure, hardcoded mapping. - Adds back tooltips for the "Dapps" and "Exchange" apps. - Replaces the implicit `strpos()` check for icon types with an explicit `icon_type` in the configuration for more robust and clear icon rendering.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Creates a new `docs/node-admin/` directory for node administrator documentation. - Adds a `configuration.md` file that explains how to use the new `homepage_apps` configuration. - Includes details on all available properties and provides examples for adding and removing apps. - Updates the documentation based on code review feedback for clarity.
- Adds a `homepage_apps` array to the config file to allow for easy customization of the homepage app blocks. - Refactors the homepage to dynamically generate the app blocks from the configuration. - Includes a fallback to a default set of apps if the configuration is not present. - Removes the use of `eval()` for conditional app display and replaces it with a secure, hardcoded mapping. - Replaces the implicit `strpos()` check for icon types with an explicit `icon_type` in the configuration for more robust and clear icon rendering. - Creates a new `docs/node-admin/` directory for node administrator documentation. - Adds a comprehensive `configuration.md` file that explains the multi-file config system and details every setting in `config.default.php`.
This commit introduces a flexible, configuration-driven system for the homepage application blocks and adds comprehensive documentation for node administrators. Key changes: - Replaces the hardcoded homepage blocks in `web/index.php` with a dynamic rendering system. - Adds a `homepage_apps` array to `config/config.default.php` to define the apps, their properties, and display conditions. - Implements secure, string-based checks for conditional logic, avoiding the use of `eval()`. - Adds an explicit `icon_type` to the configuration for robust handling of Font Awesome vs. image icons. - Creates a new `docs/node-admin/` directory. - Adds a comprehensive `configuration.md` file that explains the multi-file config system and details every setting available in the default configuration. - Updates the documentation to include a detailed guide on customizing the `homepage_apps` array.
This commit introduces a flexible, configuration-driven system for the homepage application blocks and adds comprehensive documentation for node administrators. Key changes: - Replaces the hardcoded homepage blocks in `web/index.php` with a dynamic rendering system. - Adds a `homepage_apps` array to `config/config.default.php` to define the apps, their properties, and display conditions. - Adds a commented-out example of `homepage_apps` to `config-sample.inc.php`. - Implements secure, string-based checks for conditional logic, avoiding the use of `eval()`. - Adds an explicit `icon_type` to the configuration for robust handling of Font Awesome vs. image icons. - Creates a new `docs/node-admin/` directory. - Adds a comprehensive `configuration.md` file that explains the multi-file config system and details every setting available in the default configuration. - Updates the documentation to include a detailed guide on customizing the `homepage_apps` array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the homepage app blocks configurable via the
config.default.phpfile, removing the need to edit the HTML directly. It also improves security by removing the use ofeval()and makes the icon handling more robust by using an expliciticon_typein the configuration.PR created automatically by Jules for task 7727424875893156790 started by @attogram