Fix various PHP warnings #75
Conversation
This commit fixes several PHP warnings and deprecation notices that were cluttering the nginx error log. - Fixed "Undefined array key" and "Undefined variable" warnings by using `isset()` checks, the null coalescing operator (`??`), and initializing variables. - Addressed "Trying to access array offset on value of type null" warnings by adding checks for null values before accessing array offsets. - Resolved "Deprecated: preg_match(): Passing null to parameter # 2 ($subject) of type string is deprecated" and "Deprecated: pathinfo(): Passing null to parameter # 1 ($path) of type string is deprecated" notices by ensuring the variables are not null.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit addresses two new warnings in `CommonSessionHandler.php`: - Initializes the `$out` variable to prevent an "Undefined variable" warning. - Adds a directory existence check before calling `mkdir()` to avoid a "File exists" warning.
This commit addresses a number of PHP warnings and deprecation notices, and proactively hardens the codebase against similar issues. Fixes include: - Resolved "Undefined array key" warnings by using the null coalescing operator (`??`) for `$_GET`, `$_POST`, and other array access. - Corrected "Undefined variable" warnings by initializing variables before use. - Prevented "mkdir(): File exists" warnings by adding checks with `is_dir()` before creating directories. - Addressed "Trying to access array offset on value of type null" warnings. - Fixed deprecation notices related to passing null to string functions. A proactive review of the codebase was conducted to identify and fix other similar potential warnings, making the code more robust and resilient to unexpected input.
This submission fixes various PHP warnings and deprecation notices that were cluttering the nginx error log.
PR created automatically by Jules for task 1974068608963515875 started by @attogram