CI: formatting check and test Elixir builds #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermm
force-pushed
the
ci-add-check-formatting
branch
2 times, most recently
from
2c4c694 to
8a2ab81
Compare
Collaborator
|
I really appreciate all of the formatting fixes and cleanup, but we should keep those in a separate commit from the workflow updates. I see you are still working on it, so wanted to catch you sooner rather than later. |
petermm
force-pushed
the
ci-add-check-formatting
branch
2 times, most recently
from
bd620a2 to
71bb501
Compare
Collaborator
Author
|
Yeah, adding Elixir building to tests as well, will make nice commits later.. |
petermm
force-pushed
the
ci-add-check-formatting
branch
from
a51539f to
a8db207
Compare
petermm
changed the title
petermm
force-pushed
the
ci-add-check-formatting
branch
2 times, most recently
from
13fff07 to
c5cfe3a
Compare
UncleGrumpy
requested changes
Feb 2, 2026
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Thank you so much! Just a few minor details.
Adapted from atomvm repo, remove erl fmt check in build.sh Signed-off-by: Peter M <petermm@gmail.com>
Signed-off-by: Peter M <petermm@gmail.com>
Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
ci-add-check-formatting
branch
from
c5cfe3a to
9831d5c
Compare
UncleGrumpy
approved these changes
Feb 3, 2026
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
I notice we are still using Erlang :io instead of Elixir IO in a several examples, but we should update those in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from atomvm repo
Fixes #22 and fixes #28
(There was actually a erlfmt check hidden in the build examples build.sh..)