-
Notifications
You must be signed in to change notification settings - Fork 3
PNC A11y: iFrame a11y name #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
index.js
Outdated
|
|
||
| let iframeElement = document.createElement('iframe') | ||
| iframeElement.setAttribute('allow', 'web-share') | ||
| const productType = config.product || 'Transact' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably || config.operation in the productType first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Won't this only work for the legacy config, and not the one that uses tasks[i].operation or tasks[i].product? The snapshot is showing what it'll look like for anyone using the latest config syntax: "Atomic Atomic Interface" That seems weird to me to (1) fall back to repeating "Atomic" twice in the phrase and (2) to have all of the latest config syntax fall back. |
wilsonparson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misunderstanding, this needs some work to support the latest config that we tell people to use in the docs, as well as the fall back to saying "Atomic Atomic Interface."
Reviewed with Brennen and fix Wilsons prior feedback
Linear Link
https://linear.app/atomicbuilt/issue/DD-1752/iframe-descriptive-title
Type of change
Checklist: