Skip to content

Conversation

@Adamparishspok
Copy link
Contributor

@Adamparishspok Adamparishspok commented Apr 29, 2025

Linear Link

https://linear.app/atomicbuilt/issue/DD-1752/iframe-descriptive-title

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which cleans up code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change impacts security

Checklist:

  • New and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have followed the Code Review and Code Review Security guidelines
  • I have checked my code against flaws from the OWASP Top 10
    • A01:2021-Broken Access Control
    • A02:2021-Cryptographic Failures
    • A03:2021-Injection
    • A04:2021-Insecure Design
    • A05:2021-Security Misconfiguration
    • A06:2021-Vulnerable and Outdated Components
    • A07:2021-Identification and Authentication Failures
    • A08:2021-Software and Data Integrity Failures
    • A09:2021-Security Logging and Monitoring Failures
    • A10:2021-Server-Side Request Forgery

@Adamparishspok Adamparishspok changed the title iFrame a11y name PNC A11y: iFrame a11y name Apr 29, 2025
index.js Outdated

let iframeElement = document.createElement('iframe')
iframeElement.setAttribute('allow', 'web-share')
const productType = config.product || 'Transact'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably || config.operation in the productType first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Adamparishspok Adamparishspok requested review from Tr3yb0 and removed request for sean-hill April 30, 2025 21:23
@wilsonparson
Copy link

Won't this only work for the legacy config, and not the one that uses tasks[i].operation or tasks[i].product? The snapshot is showing what it'll look like for anyone using the latest config syntax: "Atomic Atomic Interface"

That seems weird to me to (1) fall back to repeating "Atomic" twice in the phrase and (2) to have all of the latest config syntax fall back.

Copy link

@wilsonparson wilsonparson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misunderstanding, this needs some work to support the latest config that we tell people to use in the docs, as well as the fall back to saying "Atomic Atomic Interface."

@Adamparishspok Adamparishspok dismissed wilsonparson’s stale review June 23, 2025 17:11

Reviewed with Brennen and fix Wilsons prior feedback

@sean-hill sean-hill merged commit 6b65d80 into master Jun 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants