This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
this allows for the "right-click" contextual menu to show shortcuts for viewing the current
danielbayley
reviewed
Mar 9, 2017
There was a problem hiding this comment.
Would this be better with more specific targets? The context menu gets really cluttered as it is, and underutilised as a consequence. When I add any context menu items to any of my packages I try and make sure they only show up where relevant.
Something like:
'context-menu':
'.tree-view .project-root-header,
.status-bar .git-branch': [
{ label: 'Open On Github', command: 'open-on-github:repository' }
]
'.tree-view .file': [
{ label: 'Open On Github', command: 'open-on-github:file' }
]for example.
Contributor
|
@danielbayley That wouldn't work since Open on GitHub looks at the active pane item to determine which repo is open. Having the commands on the Tree View would mean that the Tree View would be the active pane item and so nothing would happen. |
Contributor
|
@50Wliu this would work once #111 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows for the "right-click" contextual menu to show shortcuts for viewing the current file
[Short description of suggestion]
Steps which explain the enhancement
Current and suggested behavior
this adds easier & maybe faster access to Open On Github functionality
Why would the enhancement be useful to most users
This adds another way to access existing functionality
Atom Version: 1.10.2
OS and Version: OS X 10.11.6