fix: don't change input schema during parsing#279
Open
pvdbosch wants to merge 4 commits intoasyncapi:masterfrom
Open
fix: don't change input schema during parsing#279pvdbosch wants to merge 4 commits intoasyncapi:masterfrom
pvdbosch wants to merge 4 commits intoasyncapi:masterfrom
Conversation
…chema-to-json-schema to 5.1.0
pvdbosch
requested review from
asyncapi-bot-eve,
fmvilas and
smoya
as code owners
2 tasks
|
Author
|
I added a commit to fix the build problem : the URL of my company's npm mirror was mistakenly used in package-lock.json |
Author
|
@fmvilas , could you review this change again? The build problem (in package-lock.json) should be fixed now. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates @openapi-contrib/openapi-schema-to-json-schema to 5.1.0
Currently used version modifies the input data when transforming from OpenAPI to JSON draft4 schema , even though
cloneSchema: trueis used.This leads to the bug described in #275 when the same schema is transformed multiple times during parsing.
This PR updates the dependency fixing this bug, and adds a test case to validate the fix.
Some type casting is necessary, because the updated dependency uses stricter typing.
This is an alternative fix to #276, which worked around the bug by cloning the input.
Related issue(s)
Resolves #275