Fix camel case format for ignored case #2000
Open
+187
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
fix-camel
branch
4 times, most recently
from
4f94d18 to
6e5255b
Compare
stof
reviewed
Dec 24, 2025
| if (preg_match('/[A-Z]{2,}/', $propertyName)) { | ||
| $propertyName = strtr($propertyName, $ignored); | ||
| if (preg_match('/[A-Z]{2,}/', $propertyName)) { | ||
| $propertyNameWithoutIgnored = strtr($propertyName, array_fill_keys($ignored, '')); |
Member
There was a problem hiding this comment.
This replacement might miss other cases where we would have another capital letter just before or after an ignored group.
The cause of the bug is that this validation overrides $propertyName instead of using a different variable name (as done here with $propertyNameWithoutIgnored). The fix is to rename the variable without changing the way its content is generated (and keeping the existing structure in $ignored)
Member
Author
There was a problem hiding this comment.
Refactored:
I kept the $ignored as a list to avoid typo and ease maintenance.
But I used array_fill_keys($ignored, 'Xx') to avoid collision with neighbors.
stof
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From AWS spec's properties we tried to normalize these name to camelCase.
For some cases, (when the name contains multiple consecutive UpperCases) where the generator is not able to generate the CamelCase value by itself, we maintain a list of (opinionated) exceptions telling that we shoiuld use the form "first char upper, rest lower". ie
ETagbecomeEtag.We also maintain a list of "ignored" cases where multiple consecutive Upper cases are fine.
ie
XOffsetstaysXOffset.The issue, is: By mistake, we also convert the second list to the form "first char upper, rest lower".
This PR fix that.
This might not be a BC break, because PHP is not strict about case on methods.. But I wonder if it worth it...