Skip to content

Conversation

@tluolamo
Copy link

@tluolamo tluolamo commented Dec 8, 2025

Summary

  • Add Pylint too-many-lines (C0302) as a preview physical-lines rule with a 1000-line default, configurable via lint.pylint.max-module-lines.
  • Wire the rule into the linter registry/checker, remove the old flake8 file-length plumbing, and expose the new setting in workspace options and schema.
  • Add inline rule tests and regenerate docs/schema.

Test Plan

  • cargo test -p ruff_linter --lib
  • cargo dev generate-all

@tluolamo tluolamo force-pushed the feat/implement-max-file-length-rule branch from 9eb6af9 to ada46d8 Compare December 8, 2025 21:21
@ntBre
Copy link
Contributor

ntBre commented Dec 8, 2025

Thanks for working on this! However, I see that this rule is crossed out in the summary of #970 with the note "not compatible with the formatter," so I don't think we want to add this rule.

@ntBre ntBre added rule Implementing or modifying a lint rule needs-decision Awaiting a decision from a maintainer labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-decision Awaiting a decision from a maintainer rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants