forked from apache/datafusion
-
Notifications
You must be signed in to change notification settings - Fork 0
example of stateless execution for projection exec #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
askalt
wants to merge
1
commit into
main
Choose a base branch
from
askalt/context-execution-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,21 @@ use itertools::izip; | |
| /// Shared [`PhysicalExpr`]. | ||
| pub type PhysicalExprRef = Arc<dyn PhysicalExpr>; | ||
|
|
||
| /// Describes execution context for the particular expression. | ||
| pub struct ExprExecutionContext { | ||
| /// External parameters. | ||
| pub external_params: Arc<[ScalarValue]>, | ||
| } | ||
|
|
||
| impl ExprExecutionContext { | ||
| /// Make a new [`ExprExecutionContext`]. | ||
| pub fn new(external_param: impl Into<Arc<[ScalarValue]>>) -> Self { | ||
| Self { | ||
| external_params: external_param.into(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// [`PhysicalExpr`]s represent expressions such as `A + 1` or `CAST(c1 AS int)`. | ||
| /// | ||
| /// `PhysicalExpr` knows its type, nullability and can be evaluated directly on | ||
|
|
@@ -430,6 +445,15 @@ pub trait PhysicalExpr: Any + Send + Sync + Display + Debug + DynEq + DynHash { | |
| fn is_volatile_node(&self) -> bool { | ||
| false | ||
| } | ||
|
|
||
| /// Make this expression executable. The most expressions are executable and do not | ||
| /// require an additional work so this method could return `self`. However, there are | ||
| /// expressions that should be transformed prior to execution, e.g. placeholder that | ||
| /// should be resolved into scalar. | ||
| fn execute( | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This way we support custom expression that should run sum logic before execution (not only dynamic filters or placeholders, but an arbitrary one). |
||
| self: Arc<Self>, | ||
| context: &ExprExecutionContext, | ||
| ) -> Result<Arc<dyn PhysicalExpr>>; | ||
| } | ||
|
|
||
| #[deprecated( | ||
|
|
@@ -662,7 +686,7 @@ pub fn is_volatile(expr: &Arc<dyn PhysicalExpr>) -> bool { | |
|
|
||
| #[cfg(test)] | ||
| mod test { | ||
| use crate::physical_expr::PhysicalExpr; | ||
| use crate::physical_expr::{ExprExecutionContext, PhysicalExpr}; | ||
| use arrow::array::{Array, BooleanArray, Int64Array, RecordBatch}; | ||
| use arrow::datatypes::{DataType, Schema}; | ||
| use datafusion_expr_common::columnar_value::ColumnarValue; | ||
|
|
@@ -707,6 +731,13 @@ mod test { | |
| fn fmt_sql(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| f.write_str("TestExpr") | ||
| } | ||
|
|
||
| fn execute( | ||
| self: Arc<Self>, | ||
| _context: &ExprExecutionContext, | ||
| ) -> datafusion_common::Result<Arc<dyn PhysicalExpr>> { | ||
| Ok(self) | ||
| } | ||
| } | ||
|
|
||
| impl Display for TestExpr { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This context is used to provide additional values for expression
execute(...)method. We could make it extendable to allow users to put their own values into it.