Fixes for module importing and latest Ionic version#34
Open
m-spyratos wants to merge 8 commits intoarielfaur:2.0from
Open
Fixes for module importing and latest Ionic version#34m-spyratos wants to merge 8 commits intoarielfaur:2.0from
m-spyratos wants to merge 8 commits intoarielfaur:2.0from
Conversation
Closed
Author
|
@arielfaur, Please let me know if you have any questions or concerns about this pull request. Currently in the repo I have uploaded the compiled files along with the source typescript files. This is not ideal and you might want to consider a building/publishing process for your plugin. For convenience, I have included two npm scripts: The first one will install the node_modules and compile the typescript files, generating the corresponding javascript and map files, and the second one will do the same as the build script, plus will publish to the npm. |
Fixed non legal calc with zero value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module Updates:
Github Page Updates:
We need to update the Github page with the following:
Import Styles
Import
ion-pullup.scssinto your app's main scss file.Inject directive in your app's module
Include pull-up in your page
Import
ion-pullup.tsin your TypeScript code.(HTML is the same)