Skip to content

Conversation

@LP1012
Copy link

@LP1012 LP1012 commented Jan 13, 2026

Summary of changes

Adds an issue template for creating figures.
Includes a short checklist of items for use by members.
This checklist would ideally be added to the ARFC website, not this issue, but I was waiting on a more-official list from Matt's PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@LP1012 LP1012 self-assigned this Jan 13, 2026
@LP1012 LP1012 linked an issue Jan 13, 2026 that may be closed by this pull request
@LP1012 LP1012 marked this pull request as ready for review January 13, 2026 17:17
@LP1012
Copy link
Author

LP1012 commented Jan 13, 2026

Adding current graduate students as reviewers because I would like their feedback on the included list.

@LP1012 LP1012 added Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request labels Jan 13, 2026
Copy link
Contributor

@ZoeRichter ZoeRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I approve - I suggested a few minor changes, but nothing critical. The link to the viridis colormap page is for future us.

Copy link
Contributor

@LukeSeifert LukeSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent for people to create an issue/sub-issue for each figure they plan to generate? If so, I wonder if maybe some of these criteria should be delegated to the website and just have a single checkbox indicating that the "Figure criteria on the website has been fulfilled".

LP1012 and others added 3 commits January 14, 2026 17:20
Co-authored-by: Zoe <39283555+ZoeRichter@users.noreply.github.com>
Co-authored-by: Zoe <39283555+ZoeRichter@users.noreply.github.com>
Co-authored-by: LukeSeifert <44068471+LukeSeifert@users.noreply.github.com>
@LP1012
Copy link
Author

LP1012 commented Jan 14, 2026

Is the intent for people to create an issue/sub-issue for each figure they plan to generate? If so, I wonder if maybe some of these criteria should be delegated to the website and just have a single checkbox indicating that the "Figure criteria on the website has been fulfilled".

I would agree (that or we put this checklist directly into a review template for the PR), but we are waiting on merging from a different PR. The plan for now was to add this in and move the list later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add figure template

3 participants