feat(pkg/boards): add IsUserPartitionPreservationSupported function #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucarin91
reviewed
Dec 16, 2025
pkg/board/os_image.go
Outdated
| // according to the current and target OS image versions. | ||
| // | ||
| // Preservation is supported if both versions are not the R0 image. | ||
| func IsUserPartitionPreservationSupported(conn remote.RemoteConn, targetImageVersion OSImageRelease) bool { |
Contributor
There was a problem hiding this comment.
I would make this a pure function; take current and target and returns if it is possible ot not to preserve user partition.
Suggested change
| func IsUserPartitionPreservationSupported(conn remote.RemoteConn, targetImageVersion OSImageRelease) bool { | |
| func IsUserPartitionPreservationSupported(current, target string) bool { |
Contributor
|
We don't have the approval requirement to squash and merge this PR?! |
Contributor
@mirkoCrobu I would wait for this #157 first. |
lucarin91
changed the title
IsUserPartitionPreservationSupported function
lucarin91
changed the title
IsUserPartitionPreservationSupported function
Contributor
|
@lucarin91 I meant that I was seeing the merge button enabled even though there was no approval. Now it is disabled! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #44
Simple check: knowing the version of the image to be flashed on the board and the version of the image currently on the board, return if it is possible to preserve the user partition during the flash operation.
If one of the current version or target version is R0, return False.
Change description
Additional Notes
Reviewer checklist
main.