Hwclock/Tz - disclaimer and display #4002
Open
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When UTC default -> Show RTC When tz selected -> Hide RTC
svartkanin
reviewed
Dec 21, 2025
| parallel_downloads: int = 0 | ||
| swap: bool = True | ||
| timezone: str = 'UTC' | ||
| timezone: str | None = None |
Collaborator
There was a problem hiding this comment.
why not leaving it here as default with all the others?
svartkanin
reviewed
Dec 21, 2025
| output = f'{tr("Timezone")}: {item.value}' | ||
| return output | ||
| else: | ||
| # Show RTC time when no timezone is selected yet |
Collaborator
There was a problem hiding this comment.
When would that happen? Isn't UTC always used as a default?
Contributor
Author
There was a problem hiding this comment.
Basically I thought it would avoid a lot of errors just to set to None + mandatory=True because it forces user not to skip this step. Do let me know if I over-edited something (first time making changes to json cfg template).
I also thought that RTC time is relevant here for people doing offline installs using archiso fully cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't find too much about this in the common issues/docs and have seen this countless times on reddit/other forums...
Why I thought it was good idea to have it in FAQ (with some more useful info) and also a visual in the TUI.
Tests:
Performed a few basics test to show concept:
None+mandatory=True