Skip to content

fix(academy): use export_data() with keyword arguments #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
honzajavorek merged 1 commit into from
Jan 13, 2026
Merged

fix(academy): use export_data() with keyword arguments #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sources/academy/webscraping/scraping_basics_python/12_framework.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,9 @@ async def main():

await crawler.run(["https://warehouse-theme-metal.myshopify.com/collections/sales"])
# highlight-next-line
await crawler.export_data_json(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data(path='dataset.json', ensure_ascii=False, indent=2)
# highlight-next-line
await crawler.export_data_csv(path='dataset.csv')
await crawler.export_data(path='dataset.csv')
```

After running the scraper again, there should be two new files in your directory, `dataset.json` and `dataset.csv`, containing all the data. If we peek into the JSON file, it should have indentation.
Expand Down Expand Up @@ -389,8 +389,8 @@ async def main():

# highlight-next-line
crawler.log.info("Exporting data")
await crawler.export_data_json(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data_csv(path='dataset.csv')
await crawler.export_data(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data(path='dataset.csv')

def parse_variant(variant):
text = variant.text.strip()
Expand Down Expand Up @@ -500,7 +500,7 @@ If you export the dataset as JSON, it should look something like this:
})

await crawler.run(["https://www.f1academy.com/Racing-Series/Drivers"])
await crawler.export_data_json(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data(path='dataset.json', ensure_ascii=False, indent=2)

if __name__ == '__main__':
asyncio.run(main())
Expand Down Expand Up @@ -598,7 +598,7 @@ When navigating to the first IMDb search result, you might find it helpful to kn
})

await crawler.run(["https://www.netflix.com/tudum/top10"])
await crawler.export_data_json(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data(path='dataset.json', ensure_ascii=False, indent=2)

if __name__ == '__main__':
asyncio.run(main())
Expand Down
4 changes: 2 additions & 2 deletions sources/academy/webscraping/scraping_basics_python/13_platform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ async def main():
await crawler.run(["https://warehouse-theme-metal.myshopify.com/collections/sales"])

crawler.log.info("Exporting data")
await crawler.export_data_json(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data_csv(path='dataset.csv')
await crawler.export_data(path='dataset.json', ensure_ascii=False, indent=2)
await crawler.export_data(path='dataset.csv')

def parse_variant(variant):
text = variant.text.strip()
Expand Down
Loading