ZOOKEEPER-4983: Add client-triggered operation count metrics #2328
+305
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
4 times, most recently
from
2b44c44 to
436ef46
Compare
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
4 times, most recently
from
16b0d7b to
b37eefd
Compare
Contributor
Author
|
@eolivelli @kezhuw @anmolnar Would you mind reviewing the PR? Thanks |
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
from
b37eefd to
71de08e
Compare
Author: Li Wang <liwang@apple.com>
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
from
71de08e to
3f0e2d4
Compare
eolivelli
reviewed
Jan 17, 2026
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
Outdated
Show resolved
Hide resolved
PDavid
reviewed
Jan 20, 2026
Contributor
PDavid
left a comment
PDavid
left a comment
There was a problem hiding this comment.
Many thanks for this improvement, looks really nice already. 👍
I just added some minor questions / comments.
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerMetricsOpCountTest.java
Show resolved
Hide resolved
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
from
adf28a5 to
6d4bec1
Compare
Author: Li Wang <liwang@apple.com>
li4wang
force-pushed
the
ZOOKEEPER-4983
branch
from
6d4bec1 to
d045a94
Compare
Contributor
Author
|
@eolivelli @PDavid Thanks for reviewing the PR and providing valuable comments. I've addressed all of them. Would you mind taking a look at it? |
li4wang
requested review from
PDavid
and removed request for
anmolnar and
kezhuw
PDavid
approved these changes
Jan 21, 2026
Contributor
PDavid
left a comment
PDavid
left a comment
There was a problem hiding this comment.
Many thanks for your improvements. Very nice! 👍
eolivelli
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes for supporting client-triggered op count metrics for more visibility of client triggered load and pattern.