[CI] Refactor Dockerfiles and installation scripts#18796
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the Continuous Integration setup by upgrading numerous core dependencies and standardizing installation practices across various Docker environments. The changes aim to improve the reliability, security, and maintainability of the CI pipelines by centralizing download verification, updating GPG key handling, and leveraging pre-built binaries where appropriate. This cleanup also removes outdated Ubuntu 20.04 specific configurations, streamlining the overall CI infrastructure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and valuable set of upgrades and cleanups to the CI infrastructure. The changes, such as upgrading dependencies, replacing apt-key with more secure methods, and switching to pre-built binaries for tools like CMake and sccache, are excellent improvements that will enhance security, build speed, and maintainability. The introduction of the download_and_verify.sh script is a great example of applying DRY principles. I have a few minor suggestions to improve consistency and robustness in some of the shell scripts.
mshr-h
force-pushed
the
docker-cleanup
branch
5 times, most recently
from
e3040bf to
d13ecf1
Compare
mshr-h
changed the title
mshr-h
force-pushed
the
docker-cleanup
branch
from
d13ecf1 to
ef90b69
Compare
…for various packages
mshr-h
force-pushed
the
docker-cleanup
branch
from
ef90b69 to
c38be7e
Compare
|
would be nice if we can followup with uv |
|
for sure! it's my next step 🚀 |
2 participants
download-and-verifyutility: reusable curl + checksum verification helper, used across install scriptsapt-key addtosigned-bykeyrings (LLVM, Vulkan, ROCm, Node.js)ENV KEY=valuesyntax,trap cleanup EXITpatterns,cmake --buildinstead ofmake, Python support narrowed to 3.10-3.11The image builds are significantly faster now.