feat: add centralized LakeFS error handling for multipart upload and dataset version operations #4177
+106
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds centralized error handling for LakeFS API calls in
DatasetResource, covering multipart upload and dataset version operations. This improves error visibility by returning meaningful HTTP status codes and error messages to the frontend. Currently, the wrapper is applied to these specific calls only, and has not yet been applied to all LakeFS calls.Changes
ApiExceptionto HTTP exception (400, 401, 403, 404, 409, 410, 412, 416, 420, 500)createDatasetVersion,getDatasetDiff,initMultipartUpload,finishMultipartUpload,abortMultipartUploadAny related issues, documentation, discussions?
Related to #4176
How was this PR tested?
DatasetResourceSpecfor error message response and 500 internal error handlingWas this PR authored or co-authored using generative AI tooling?
Generated-by: Claude (Anthropic)