-
Notifications
You must be signed in to change notification settings - Fork 112
feat: introduce materialized execution mode #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will mark this PR ready after adding test cases. |
Yicong-Huang
previously requested changes
Jan 14, 2026
...rc/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala
Outdated
Show resolved
Hide resolved
frontend/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts
Outdated
Show resolved
Hide resolved
Xiao-zhen-Liu
approved these changes
Jan 22, 2026
Contributor
Xiao-zhen-Liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Left a few comments.
...cala/org/apache/texera/amber/engine/architecture/scheduling/CostBasedScheduleGenerator.scala
Outdated
Show resolved
Hide resolved
amber/src/test/scala/org/apache/texera/amber/engine/e2e/DataProcessingSpec.scala
Outdated
Show resolved
Hide resolved
frontend/src/app/workspace/component/left-panel/settings/settings.component.ts
Outdated
Show resolved
Hide resolved
...on/workflow-core/src/main/scala/org/apache/texera/amber/core/workflow/WorkflowSettings.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
We are introducing a materialized execution mode alongside the existing pipelined execution mode.
To support this, a new workflow setting called execution mode has been added, along with a corresponding backend flag. Materialized and pipelined execution are treated as the same level and are represented as an enum in the configuration.
We also introduce a flag named
defaultExecutionMode, whose value is set topipelined.Any related issues, documentation, discussions?
This PR resolves issue #4157.
How was this PR tested?
Tested with the existing test cases and test cases added for MATERIALIZED ExecutionMode:
DataProcessingSpec.scala): Added 10 test cases verifying that workflows with various operator combinations (CSV/JSONL sources, filters, aggregations, joins) execute correctly in MATERIALIZED mode and produce the same results as PIPELINED mode.CostBasedScheduleGeneratorSpec.scala): Added 5 test cases verifying that CostBasedScheduleGenerator correctly creates one region per operator in MATERIALIZED mode, with assertions confirming: (1) only 1 state explored, (2) number of regions equals number of operators, (3) each region contains exactly 1 operator, and (4) all physical links become materialized region boundaries.Was this PR authored or co-authored using generative AI tooling?
No.