Skip to content

Conversation

@mengw15
Copy link
Contributor

@mengw15 mengw15 commented Feb 18, 2025

This pull request enables users to assign certain operators (except for source operators) to a specific computing node. The configuration is located under the operator’s Advanced Settings. Two new properties are introduced:

  1. autoSelectNodeAddress (boolean)
  • Defaults to true.

  • When true, the system uses the existing round-robin mechanism to automatically assign a computing node address.

  • When set to false, the user can manually specify a computing node address.

截屏2025-02-20 上午6 05 55
  1. Designated Node Address
  • Only visible when autoSelectNodeAddress is set to false.

  • Displays a dropdown of all available node addresses for the user to choose from.

截屏2025-02-20 上午6 06 14

This feature allows for more flexible control over where operators run within the cluster

@mengw15 mengw15 marked this pull request as draft February 18, 2025 10:34
@mengw15 mengw15 self-assigned this Feb 18, 2025
@mengw15 mengw15 requested a review from shengquan-ni February 20, 2025 14:15
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to manually add "applyManualLocation(baseOp)" to every operator? Is there a way to automatically bypass this step if the operator has only one worker? I think it's even ok to show this option on all operators, and for the operators with only one possible assignment, you only show the one option in the dropdown.

@mengw15 mengw15 requested a review from bobbai00 April 5, 2025 17:31
Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

Please update the screenshot in the PR description.

@bobbai00 bobbai00 changed the title Operator's location assignment Add Advanced Settings section to enable users assign certain worker nodes for operators. Apr 14, 2025
@mengw15 mengw15 requested a review from bobbai00 April 14, 2025 11:47
@bobbai00 bobbai00 changed the title Add Advanced Settings section to enable users assign certain worker nodes for operators. Add Advanced Settings in the property panel to allow users assign certain worker nodes for operators. Apr 15, 2025
@Yicong-Huang
Copy link
Contributor

We will continue investigating this issue later, after we agree on the design of the "Execution Env".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants