Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds Kubernetes deployment manifests and supporting documentation for deploying StreamPark and its MySQL instance in a k8s environment. Key changes include:
- A new deployment and service manifest for StreamPark (streampark.yml)
- A new StatefulSet and service manifest for MySQL (streampark-mysql.yml) with a corresponding ConfigMap
- An updated markdown guide (k8s部署StreamPark.md) detailing the deployment process and custom Dockerfile instructions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| k8s-yml/streampark.yml | Added Deployment and Service for StreamPark |
| k8s-yml/streampark-mysql.yml | Added ConfigMap, StatefulSet, and Service for MySQL |
| k8s-yml/k8s部署StreamPark.md | New documentation for building images and deploying StreamPark |
Files not reviewed (1)
- k8s-yml/Dockerfile: Language not supported
| - | | ||
| export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk | ||
| /apache-streampark_2.12-2.1.5/bin/startup.sh | ||
| sleep 9999d |
There was a problem hiding this comment.
[nitpick] Using 'sleep 9999d' to keep the container running is a non-standard approach that could mask startup issues; consider implementing a proper lifecycle management strategy or process supervision instead.
| secure-file-priv= NULL | ||
|
|
There was a problem hiding this comment.
The configuration option 'secure-file-priv' appears to be incorrectly named; it should likely be 'secure_file_priv' to match MySQL's expected parameter name.
| secure-file-priv= NULL | |
| secure_file_priv = NULL |
|
应该做成 helm chart 会比较通用一点 |
|
是专门再拉一个docker的镜像来提供docker.sock？streampark可以不通过docker.sock么？ |
3 participants
贡献目前k8s部署StreamPark文档！我们生产已经使用这种方式部署！