Skip to content

Conversation

@absolute8511
Copy link
Contributor

Change-Id: I675064c4432b6848ddea8cae803ed978f03bd07f

Which Issue(s) This PR Fixes

Fixes #9956

Brief Description

How Did You Test This Change?

Change-Id: I675064c4432b6848ddea8cae803ed978f03bd07f
@absolute8511 absolute8511 changed the title fix: avoid revive stuck for lots of near same invisible cks [ISSUE #9956] fix: avoid revive stuck for lots of near same invisible cks Dec 24, 2025
Change-Id: Ie2fb84abb7e9a3389ffec41be140b33d99d84911
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.74%. Comparing base (b5da00a) to head (9fc9429).

Files with missing lines Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 82.35% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9957      +/-   ##
=============================================
- Coverage      48.81%   48.74%   -0.07%     
+ Complexity     12760    12748      -12     
=============================================
  Files           1324     1324              
  Lines          96407    96416       +9     
  Branches       12435    12439       +4     
=============================================
- Hits           47057    47000      -57     
- Misses         43605    43665      +60     
- Partials        5745     5751       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Change-Id: Id78e5ee4ed75f638630a6756cce19d391fa5106c
@qianye1001
Copy link
Contributor

It is recommended to use the new features of pop on Rocksdb. The old pop implementation will be deprecated in a future version.
pop on Rocksdb

@absolute8511
Copy link
Contributor Author

It is recommended to use the new features of pop on Rocksdb. The old pop implementation will be deprecated in a future version. pop on Rocksdb

The pop on rocksdb currently still need be verified and can not be synced to slaves. So the old implement maybe still be used by most of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PopReviveService may stuck on check if many messages change invisible in the same time.

3 participants