[spark] Support UPDATE on Paimon append-only table in spark V2 write #7097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerwin-zk
force-pushed
the
v2-update-append-table
branch
6 times, most recently
from
7f4431c to
7b3ff79
Compare
Zouxxyy
reviewed
Jan 23, 2026
paimon-spark/paimon-spark-3.5/src/test/scala/org/apache/paimon/spark/sql/UpdateTableTest.scala
Outdated
Show resolved
Hide resolved
kerwin-zk
force-pushed
the
v2-update-append-table
branch
2 times, most recently
from
024e1ba to
2086847
Compare
kerwin-zk
force-pushed
the
v2-update-append-table
branch
from
2086847 to
c8f9ae8
Compare
YannByron
reviewed
Jan 29, 2026
| /** Determines if DataSourceV2 update is not supported for the given table. */ | ||
| protected def shouldFallbackToV1Update(table: SparkTable, updateTable: UpdateTable): Boolean = { | ||
| shouldFallbackToV1(table) || | ||
| !updateTable.rewritable || |
Contributor
There was a problem hiding this comment.
updateTable.rewritable should always be true here, right?
YannByron
reviewed
Jan 29, 2026
| extensions.injectPostHocResolutionRule(_ => PaimonDeleteTable) | ||
| extensions.injectPostHocResolutionRule(spark => PaimonMergeInto(spark)) | ||
|
|
||
| extensions.injectPostHocResolutionRule(_ => RewritePaimonV2UpdateTable) |
Contributor
There was a problem hiding this comment.
I suggest to use one single-rule to deal with update operations. In it, we can always align assignments first, and then chose the v1/v2 code plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support UPDATE on Paimon append-only table in spark V2 write
Tests
CI