tools: fix `make host_info` flag parsing and config string escaping #18299

adwait-godbole · 2026-02-01T19:05:25Z

This PR fixes incorrect flag handling and string escaping in the make host_info diagnostic target.

The previous implementation passed compilation flags in a way that caused incorrect splitting and over-escaping, leading to malformed diagnostic output and incorrectly quoted configuration values.

The fixes ensure that:

CFLAGS, CXXFLAGS, and LDFLAGS are passed and parsed correctly
Configuration values are escaped exactly once when generating sysinfo.h
The parsed output accurately reflects the contents of the .config file

This is a diagnostic-only change and does not affect the NuttX build output.

Fixes #16696

cc: @acassis

acassis · 2026-02-01T19:36:02Z

@adwait-godbole I don't know if you need to add quotes to every lines, my ideas was to fix just:

from:
CONFIG_ARCH_BOARD=\weact-stm32h743\

to:
CONFIG_ARCH_BOARD="weact-stm32h743"

@raiden00pl @xiaoxiang781216 what do you think?

adwait-godbole · 2026-02-02T01:58:21Z

Hi @acassis. Thanks for the quick feedback. From the screenshots I’ve attached in the PR description, I’ve already been able to achieve this:

before:

CONFIG_APPS_DIR=\../apps\

after (this PR):

“CONFIG_APPS_DIR=“../apps””

So removing those wrapping double quotes won’t be much of an issue. I’ll do that fix.

Just wanted to confirm one thing. Do we only want to do this (remove wrapping double quotes) for CONFIG_* options or for everything that is getting dumped on the terminal? I mean do we also want this:

My current PR changes:

NuttX LDFLAGS:
   “-Wl—gc-sections”

Your Requirement:

NuttX LDFLAGS:
   -Wl—gc-sections

? Let me know.

acassis · 2026-02-02T11:32:08Z

   -Wl—gc-sections

Hi @adwait-godbole I think everything should have these double quote, only some strings after CONFIG_XXX..= should include "yyyy". So basically remote the initial and the ending quote of each line will fix the issue

simbit18 · 2026-02-02T12:55:58Z

Hi @adwait-godbole please fix

====================================================================================

Configuration/Tool: esp32-devkitc/nxdiag
2026-02-01 20:19:24
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
In file included from nxdiag.c:36:
Error: sysinfo.h:17:293: error: 'github' undeclared here (not in a function)
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                     ^~~~~~
Error: sysinfo.h:17:300: error: 'workspace' undeclared here (not in a function)
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                            ^~~~~~~~~
Error: sysinfo.h:17:310: error: 'sources' undeclared here (not in a function)
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                                      ^~~~~~~
Error: sysinfo.h:17:318: error: 'apps' undeclared here (not in a function)
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                                              ^~~~
Error: sysinfo.h:17:323: error: 'include' undeclared here (not in a function); did you mean 'inode'?
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                                                   ^~~~~~~
      |                                                                                                                                                                                                                                                                                                                                   inode
Error: sysinfo.h:17:330: error: expected '}' before string constant
   17 |   "-fno-common -Wall -Wstrict-prototypes -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -Wno-psabi -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                                                                                                                                                                                                                                                          ^~
sysinfo.h:16:1: note: to match this '{'
   16 | {
      | ^
Error: sysinfo.h:23:105: error: expected '}' before 'gnu'
   23 |   "-fno-common -Wall -Wshadow -Wundef -Wno-attributes -Wno-unknown-pragmas -nostdinc++ -Wno-psabi -std="gnu++17" -fno-exceptions -fcheck-new -fno-rtti -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -mlongcalls -isystem /github/workspace/sources/nuttx/include/cxx -isystem /github/workspace/sources/nuttx/include -D__NuttX__ -DNDEBUG -Wno-cpp -Werror -I "/github/workspace/sources/apps/include"",
      |                                                                                                         ^~~
sysinfo.h:22:1: note: to match this '{'
   22 | {
      | ^
make[2]: *** [/github/workspace/sources/apps/Application.mk:330: nxdiag.c.github.workspace.sources.apps.system.nxdiag.o] Error 1
make[2]: Target 'all' not remade because of errors.
make[1]: *** [Makefile:54: /github/workspace/sources/apps/system/nxdiag_all] Error 2
make[1]: Target 'all' not remade because of errors.
make: *** [tools/LibTargets.mk:248: /github/workspace/sources/apps/libapps.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  [1/1] Normalize esp32-devkitc/nxdiag
====================================================================================

adwait-godbole · 2026-02-03T12:10:40Z

Hi @acassis @simbit18. Please re-review. Thanks :).

adwait-godbole · 2026-02-03T12:16:27Z

@simbit18. Please let me know if you're still facing the same failure.

simbit18 · 2026-02-03T13:47:38Z

Hi @adwait-godbole, you need to run the tests with this configuration esp32-devkitc:nxdiag

CC:  exec_builtin.c 
make[2]: Leaving directory '/github/workspace/sources/apps/builtin'
make[2]: Entering directory '/github/workspace/sources/apps/nshlib'
CC:  nsh_alias.c 
CC:  nsh_builtin.c 
CC:  nsh_command.c 
CC:  nsh_console.c 
CC:  nsh_consolemain.c 
CC:  nsh_dbgcmds.c 
CC:  nsh_envcmds.c 
CC:  nsh_fscmds.c 
CC:  nsh_fsutils.c 
CC:  nsh_init.c 
CC:  nsh_mmcmds.c 
CC:  nsh_mntcmds.c 
CC:  nsh_parse.c 
CC:  nsh_printf.c 
CC:  nsh_proccmds.c 
CC:  nsh_prompt.c 
CC:  nsh_script.c 
CC:  nsh_session.c 
CC:  nsh_syscmds.c 
CC:  nsh_system.c 
CC:  nsh_test.c 
CC:  nsh_timcmds.c 
CC:  nsh_wait.c 
make[2]: Leaving directory '/github/workspace/sources/apps/nshlib'
make[2]: Entering directory '/github/workspace/sources/apps/platform'
CC:  board/dummy.c 
make[2]: Leaving directory '/github/workspace/sources/apps/platform'
make[2]: Entering directory '/github/workspace/sources/apps/system/dd'
CC:  dd_main.c 
make[2]: Leaving directory '/github/workspace/sources/apps/system/dd'
make[2]: Entering directory '/github/workspace/sources/apps/system/nsh'
CC:  nsh_main.c 
CC:  sh_main.c 
make[2]: Leaving directory '/github/workspace/sources/apps/system/nsh'
make[2]: Entering directory '/github/workspace/sources/apps/system/nxdiag'
if ([ $? -ne 0 ]); then \
	echo "ERROR: Failed to generate sysinfo.h"; \
	exit 1; \
fi
CC:  nxdiag.c 
In file included from nxdiag.c:36:
Error: sysinfo.h:35:21: error: 'y' undeclared here (not in a function)
   35 |   CONFIG_HOST_LINUX=y,
      |                     ^
Error: sysinfo.h:36:18: error: assignment to expression with array type
   36 |   CONFIG_APPS_DIR="../apps",
      |                  ^
Error: sysinfo.h:37:24: error: assignment to expression with array type
   37 |   CONFIG_BASE_DEFCONFIG="esp32-devkitc:nxdiag",
      |                        ^
Error: sysinfo.h:44:24: error: lvalue required as left operand of assignment
   44 |   CONFIG_FORTIFY_SOURCE=0,
      |                        ^
Error: sysinfo.h:48:29: error: lvalue required as left operand of assignment
   48 |   CONFIG_STACK_USAGE_WARNING=0,
      |                             ^
Error: sysinfo.h:55:14: error: assignment to expression with array type
   55 |   CONFIG_ARCH="xtensa",
      |              ^
Error: sysinfo.h:56:19: error: assignment to expression with array type
   56 |   CONFIG_ARCH_CHIP="esp32",
      |                   ^
Error: sysinfo.h:57:31: error: assignment to expression with array type
   57 |   CONFIG_ESPRESSIF_CHIP_SERIES="esp32",
      |                               ^
Error: sysinfo.h:58:28: error: lvalue required as left operand of assignment
   58 |   CONFIG_ESPRESSIF_NUM_CPUS=2,
      |                            ^
Error: sysinfo.h:62:30: error: assignment to expression with array type
   62 |   CONFIG_ESPRESSIF_FLASH_FREQ="40m",
      |                              ^
Error: sysinfo.h:65:27: error: lvalue required as left operand of assignment
   65 |   CONFIG_XTENSA_CP_INITSET=0x0001,
      |                           ^
Error: sysinfo.h:74:36: error: lvalue required as left operand of assignment
   74 |   CONFIG_ESP32_DEFAULT_CPU_FREQ_MHZ=240,
      |                                    ^
Error: sysinfo.h:76:39: error: lvalue required as left operand of assignment
   76 |   CONFIG_ESP_PHY_IRQSTATE_FLAGS_NUMBER=3,
      |                                       ^
Error: sysinfo.h:80:31: error: lvalue required as left operand of assignment
   80 |   CONFIG_ESP32_BT_RESERVE_DRAM=0,
      |                               ^
Error: sysinfo.h:81:37: error: lvalue required as left operand of assignment
   81 |   CONFIG_ESP32_TRACEMEM_RESERVE_DRAM=0,
      |                                     ^
Error: sysinfo.h:82:38: error: lvalue required as left operand of assignment
   82 |   CONFIG_ESP32_ULP_COPROC_RESERVE_MEM=0,
      |                                      ^

adwait-godbole · 2026-02-03T15:43:43Z

@simbit18 the esp32-devkitc:nxdiag test has now passed in the CI -> https://github.com/apache/nuttx/actions/runs/21633827066/job/62353972303?pr=18299. I hope everything else turns green as well :).

adwait-godbole · 2026-02-03T17:57:48Z

@simbit18 good to go?

simbit18 · 2026-02-04T11:03:03Z

@adwait-godbole Thank you so much !

Did @acassis resolve your request?

@fdcavalcanti @tmedicci @eren-terzioglu Is this acceptable for your internal tests?

eren-terzioglu · 2026-02-04T11:05:35Z

@adwait-godbole Thank you so much !

Did @acassis resolve your request?

@fdcavalcanti @tmedicci @eren-terzioglu Is this acceptable for your internal tests?

Hi,
I am testing right now.

eren-terzioglu · 2026-02-04T11:16:15Z

esp32-devkitc:nxdiag built fine but make host_info is giving this output. Is it happening on your machines too after the updates?

$ ./tools/configure.sh esp32-devkitc:nxdiag; make -j
...
Successfully created esp32 image.
Generated: nuttx.bin

$ make host_info
file sysinfo.h not exists
usage: host_info_dump.py [-h] [-m] [-k] [-p] [-c] [-f CFLAGS CXXFLAGS LDFLAGS]
                         [--verbose] [--target_info]
                         nuttx_path
host_info_dump.py: error: argument -f/--flags: expected 3 arguments
make: *** [tools/Unix.mk:644: host_info] Error 2

$ sudo make host_info
[sudo] password for eren: 
/usr/bin/bash: line 1: xtensa-esp32-elf-gcc: command not found
No matching array found.

adwait-godbole · 2026-02-04T11:17:46Z

@eren-terzioglu I'll look into this. Thanks.

Fix incorrect flag handling and string escaping in the `make host_info` diagnostic target. Previously, CFLAGS, CXXFLAGS, and LDFLAGS were passed in a form that caused improper splitting and quoting, which resulted in malformed output and incorrectly escaped configuration values such as CONFIG_APPS_DIR. This change ensures that: - Compilation flags are passed as proper shell strings - Flags are split correctly using shlex - Configuration values are escaped exactly once when generating sysinfo.h - Parsed output matches the contents of the .config file This change affects diagnostic output only and does not modify the NuttX build process or generated binaries. Signed-off-by: Adwait Godbole <adwaitngodbole@gmail.com>

adwait-godbole requested review from simbit18 and xiaoxiang781216 as code owners February 1, 2026 19:05

github-actions bot added Area: Tooling Area: Build system Size: S The size of the change in this PR is small labels Feb 1, 2026

xiaoxiang781216 previously approved these changes Feb 2, 2026

View reviewed changes

adwait-godbole dismissed xiaoxiang781216’s stale review via 5bfc091 February 3, 2026 12:00

adwait-godbole force-pushed the tools/host_info-fix branch 3 times, most recently from 7a41efc to fece44c Compare February 3, 2026 12:08

jerpelea previously approved these changes Feb 3, 2026

View reviewed changes

acassis previously approved these changes Feb 3, 2026

View reviewed changes

simbit18 requested review from fdcavalcanti and tmedicci February 3, 2026 13:50

adwait-godbole dismissed stale reviews from acassis and jerpelea via d3d44b8 February 3, 2026 14:16

adwait-godbole force-pushed the tools/host_info-fix branch from d3d44b8 to 058621b Compare February 3, 2026 14:18

adwait-godbole force-pushed the tools/host_info-fix branch from 058621b to 781b417 Compare February 4, 2026 13:03

adwait-godbole requested review from btashton, lupyuen and yamt as code owners February 4, 2026 13:03

github-actions bot added Area: CI Size: M The size of the change in this PR is medium labels Feb 4, 2026

adwait-godbole force-pushed the tools/host_info-fix branch 2 times, most recently from 92332e7 to 989238f Compare February 4, 2026 18:24

adwait-godbole force-pushed the tools/host_info-fix branch from 989238f to 061c4c7 Compare February 4, 2026 19:06

tools: fix make host_info flag parsing and config string escaping #18299

Are you sure you want to change the base?

tools: fix make host_info flag parsing and config string escaping #18299

Conversation

adwait-godbole commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acassis commented Feb 1, 2026

Uh oh!

adwait-godbole commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acassis commented Feb 2, 2026

Uh oh!

simbit18 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adwait-godbole commented Feb 3, 2026

Uh oh!

adwait-godbole commented Feb 3, 2026

Uh oh!

simbit18 commented Feb 3, 2026

Uh oh!

adwait-godbole commented Feb 3, 2026

Uh oh!

adwait-godbole commented Feb 3, 2026

Uh oh!

simbit18 commented Feb 4, 2026

Uh oh!

eren-terzioglu commented Feb 4, 2026

Uh oh!

eren-terzioglu commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adwait-godbole commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tools: fix `make host_info` flag parsing and config string escaping #18299

tools: fix `make host_info` flag parsing and config string escaping #18299

adwait-godbole commented Feb 1, 2026 •

edited

Loading

adwait-godbole commented Feb 2, 2026 •

edited

Loading

simbit18 commented Feb 2, 2026 •

edited

Loading

eren-terzioglu commented Feb 4, 2026 •

edited

Loading