testing/{ostest,sched/smp}: Remove BOARD_LOOPSPERMSEC references#3401
Open
linguini1 wants to merge 1 commit intoapache:masterfrom
Open
testing/{ostest,sched/smp}: Remove BOARD_LOOPSPERMSEC references#3401linguini1 wants to merge 1 commit intoapache:masterfrom
linguini1 wants to merge 1 commit intoapache:masterfrom
Conversation
In an effort to avoid unexpected behaviour from users not calibrating BOARD_LOOPSPERMSEC, a compilation error occurs when it is undefined. On some systems, this is allowed (those that use timer implementations instead of busy-looping for delays). In these cases, we should busy-loop using the clock time instead of relying on a possibly undefined/uncalibrated macro. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
linguini1
requested review from
acassis,
cederom,
hartmannathan,
jerpelea,
michallenc and
simbit18
cederom
approved these changes
Feb 5, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @linguini1 :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In an effort to avoid unexpected behaviour from users not calibrating BOARD_LOOPSPERMSEC, a compilation error occurs when it is undefined. On some systems, this is allowed (those that use timer implementations instead of busy-looping for delays). In these cases, we should busy-loop using the clock time instead of relying on a possibly undefined/uncalibrated macro.
Closes #3345
Impact
Impacts the OSTest cases
sporadicandsporadic2, as well as thesched/smptest.
Testing
Compilation for
qemu-armv8a:nsh_smpnow passes (this is the configurationfailing due to missing symbol
CONFIG_BOARDLOOPSPERMSECin apache/nuttx#17011).Details
Running the SMP test on this configuration as-is passes:
Details
With
CONFIG_SCHED_SPORADIC=y(so modified code is compiled into ostest), ostest passes:Details