NIFI-15307 ConsumeKinesis. Wait for long initialization in onTrigger #10664
+77
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelless
commented
Dec 18, 2025
|
|
||
| @Override | ||
| public void onTrigger(final ProcessContext context, final ProcessSession session) throws ProcessException { | ||
| if (!initialized.get()) { |
Contributor
Author
There was a problem hiding this comment.
Short-circuiting by checking a bool variable, so we don't have to inspect the content of the future after initialization completed.
exceptionfactory
requested changes
Dec 20, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for adjusting the initialization approach @awelless. Although the initial long duration is a general concern, this adjusted approach is a helpful improvement. I recommend some minor implementation adjustments, and raised a concern on test timing.
|
|
||
| @Test | ||
| // It takes around 30 seconds for a scheduler to fail in this test. | ||
| @Timeout(value = 3, unit = TimeUnit.MINUTES, threadMode = SEPARATE_THREAD) |
Contributor
There was a problem hiding this comment.
This is too long for a unit test. One option is moving this to an integration test. Another option is to remove the test method.
| private volatile @Nullable ReaderRecordProcessor readerRecordProcessor; | ||
|
|
||
| private volatile Future<InitializationResult> initializationResultFuture; | ||
| private volatile AtomicBoolean initialized; |
Contributor
There was a problem hiding this comment.
Recommend setting a final value to avoid null checking.
Suggested change
| private volatile AtomicBoolean initialized; | |
| private final AtomicBoolean initialized = new AtomicBoolean(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15307
Waiting for initial initialization to complete in
OnScheduledis interrupted by exceeding the timeout. This doesn't cancel resource creation on the AWS side, so after a few restarts the processor is working as expected.To provide a better user experience, the processor waits only for 30 seconds for the initialization in
OnScheduled. This should be enough when the needed AWS resources are in place.If 30 seconds were not enough, the processor will wait in the
onTriggermethod.The change was also tested manually.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation