Skip to content

Conversation

@Polandia94
Copy link
Contributor

@Polandia94 Polandia94 commented Mar 10, 2025

Add signed upload to azure and s3

Description

Add upload methods on get_object_cdn on azure blob storage and s3, using the same parameters.

Related:
#1458

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.35%. Comparing base (ae6e522) to head (72262a8).
⚠️ Report is 40 commits behind head on trunk.

Files with missing lines Patch % Lines
libcloud/storage/drivers/azure_blobs.py 66.67% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2058   +/-   ##
=======================================
  Coverage   83.34%   83.35%           
=======================================
  Files         353      353           
  Lines       81769    81797   +28     
  Branches     8993     8998    +5     
=======================================
+ Hits        68148    68174   +26     
- Misses      10796    10797    +1     
- Partials     2825     2826    +1     
Files with missing lines Coverage Δ
libcloud/storage/drivers/ovh.py 80.00% <100.00%> (ø)
libcloud/storage/drivers/s3.py 89.63% <100.00%> (ø)
libcloud/storage/drivers/scaleway.py 80.77% <100.00%> (ø)
libcloud/test/storage/test_aurora.py 100.00% <100.00%> (ø)
libcloud/test/storage/test_azure_blobs.py 94.55% <100.00%> (+0.06%) ⬆️
libcloud/test/storage/test_s3.py 94.04% <100.00%> (+0.11%) ⬆️
libcloud/storage/drivers/azure_blobs.py 86.78% <66.67%> (-0.34%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micafer
Copy link
Contributor

micafer commented Feb 12, 2026

Thanks for your contribution, and sorry for de delay in the review.
I have some comments:

In s3.py and azure_blobs.py: ex_method is Literal["GET", "PUT", "DELETE"]
but in In ovh.py and scaleway.py: ex_method is str
This should be consistent across all drivers. I recommend using Literal.

In azure_blobs.py, the docstring does not document the new ex_method parameter.
In s3.py, the docstring does not document the new parameter.
In ovh.py and scaleway.py, the docstring has not been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants