Skip to content

JCR-5229: LockedWrapperTest.testSequenceWithSessionRefresh() may fail due to race conditions #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaedke merged 1 commit into from
Feb 18, 2026
+16 −13
Merged

JCR-5229: LockedWrapperTest.testSequenceWithSessionRefresh() may fail due to race conditions #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions jackrabbit-core/src/test/java/org/apache/jackrabbit/core/LockedWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,22 +305,25 @@ public Long call() throws RepositoryException, InterruptedException {
}
Node n = s.getNode(counterPath);

long value = new LockedWrapper<Long>() {
long value = 0;
synchronized (counter) {
value = new LockedWrapper<Long>() {

@Override
protected Long run(Node node)
throws RepositoryException {
@Override
protected Long run(Node node)
throws RepositoryException {

Property seqProp = node.getProperty("value");
long value = seqProp.getLong();
seqProp.setValue(++value);
s.save();
return value;
}
}.with(n, false);
Property seqProp = node.getProperty("value");
long value = seqProp.getLong();
seqProp.setValue(++value);
s.save();
return value;
}
}.with(n, false);

// check that the sequence is ok
assertEquals(counter.getAndIncrement(), value);
// check that the sequence is ok
assertEquals(counter.getAndIncrement(), value);
}

// do a random wait
Thread.sleep(random.nextInt(100));
Expand Down