Skip to content

[To dev/1.3] Pipe: Optimized the error code of illegal pipe / pipe plugin name string #17206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: dev/1.3
Choose a base branch
from
+8 −7
Open

[To dev/1.3] Pipe: Optimized the error code of illegal pipe / pipe plugin name string #17206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-test/src/test/java/org/apache/iotdb/pipe/it/autocreate/IoTDBPipeSyntaxIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ public void testPipePluginValidation() {
fail();
} catch (final SQLException e) {
Assert.assertEquals(
"1603: Failed to get executable for PipePlugin TestProcessor, please check the URI.",
"701: Failed to get executable for PipePlugin TestProcessor, please check the URI.",
e.getMessage());
}
try {
Expand Down
1 change: 1 addition & 0 deletions iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/TSStatusCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ public enum TSStatusCode {
CREATE_PIPE_PLUGIN_ERROR(1600),
DROP_PIPE_PLUGIN_ERROR(1601),
PIPE_PLUGIN_LOAD_CLASS_ERROR(1602),
@Deprecated
PIPE_PLUGIN_DOWNLOAD_ERROR(1603),
CREATE_PIPE_PLUGIN_ON_DATANODE_ERROR(1604),
DROP_PIPE_PLUGIN_ON_DATANODE_ERROR(1605),
Expand Down
12 changes: 6 additions & 6 deletions ...apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,15 +820,15 @@ public SettableFuture<ConfigTaskResult> createPipePlugin(
future.setException(
new IoTDBException(
String.format("Failed to create pipe plugin %s. " + pathError, pluginName),
TSStatusCode.CREATE_PIPE_PLUGIN_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}

if (uriString == null || uriString.isEmpty()) {
future.setException(
new IoTDBException(
"Failed to create pipe plugin, because the URI is empty.",
TSStatusCode.PIPE_PLUGIN_DOWNLOAD_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}

Expand All @@ -843,7 +843,7 @@ public SettableFuture<ConfigTaskResult> createPipePlugin(
future.setException(
new IoTDBException(
"The scheme of URI is not set, please specify the scheme of URI.",
TSStatusCode.PIPE_PLUGIN_DOWNLOAD_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}
if (!uri.getScheme().equals("file")) {
Expand Down Expand Up @@ -882,7 +882,7 @@ public SettableFuture<ConfigTaskResult> createPipePlugin(
"Failed to get executable for PipePlugin "
+ createPipePluginStatement.getPluginName()
+ ", please check the URI.",
TSStatusCode.PIPE_PLUGIN_DOWNLOAD_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}

Expand Down Expand Up @@ -1799,7 +1799,7 @@ public SettableFuture<ConfigTaskResult> createPipe(
String.format(
"Failed to create pipe %s, pipe name starting with \"%s\" are not allowed to be created.",
pipeName, PipeStaticMeta.SYSTEM_PIPE_PREFIX),
TSStatusCode.PIPE_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}

Expand All @@ -1808,7 +1808,7 @@ public SettableFuture<ConfigTaskResult> createPipe(
future.setException(
new IoTDBException(
String.format("Failed to create pipe %s, " + pathError, pipeName),
TSStatusCode.PIPE_ERROR.getStatusCode()));
TSStatusCode.SEMANTIC_ERROR.getStatusCode()));
return future;
}

Expand Down
Loading