IGNITE-27626 Use MessageSerializer for custom messages#12651
Open
shishkovilja wants to merge 5 commits intoapache:masterfrom
Open
IGNITE-27626 Use MessageSerializer for custom messages#12651shishkovilja wants to merge 5 commits intoapache:masterfrom
shishkovilja wants to merge 5 commits intoapache:masterfrom
Conversation
shishkovilja
force-pushed
the
ignite-27626
branch
2 times, most recently
from
f529d25 to
6ee242b
Compare
shishkovilja
changed the title
shishkovilja
force-pushed
the
ignite-27626
branch
6 times, most recently
from
4e7c1db to
bae6713
Compare
shishkovilja
force-pushed
the
ignite-27626
branch
from
50cdcd5 to
f87dbb3
Compare
|
wernerdv
reviewed
Feb 3, 2026
.../main/java/org/apache/ignite/internal/processors/cache/CacheStatisticsModeChangeMessage.java
Outdated
Show resolved
Hide resolved
wernerdv
reviewed
Feb 3, 2026
...c/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryCustomEventMessage.java
Outdated
Show resolved
Hide resolved
wernerdv
reviewed
Feb 3, 2026
| msg = (DiscoveryCustomMessage)serMsg; | ||
| else { | ||
| try { | ||
| msg = U.unmarshal(marsh, msgBytes, ldr); |
Contributor
There was a problem hiding this comment.
Should we add a check that msgBytes != null?
Contributor
Author
There was a problem hiding this comment.
In fact, if msgBytes == null, it is an incorrect state of message. Unmarshal will fail with an asserion error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.