IGNITE-27473: WALMode consistency check and tests by DEADripER · Pull Request #12642 · apache/ignite

DEADripER · 2026-01-19T10:32:46Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

wernerdv · 2026-01-19T12:01:03Z

...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java


+        DataStorageConfiguration dsCfg = ctx.config().getDataStorageConfiguration();
+
+        if (dsCfg != null)


Suggested change

if (dsCfg != null)

if (CU.isPersistenceEnabled(dsCfg))

To avoid test failures in IgniteKernalSelfTestSuite, let’s do the following:

ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg != null ? dsCfg.getWalMode().ordinal() : DataStorageConfiguration.DFLT_WAL_MODE.ordinal());

wernerdv · 2026-01-19T12:12:59Z

...rg/apache/ignite/internal/managers/discovery/GridDiscoveryManagerWalModeConsistencyTest.java

+
+        GridTestUtils.assertThrowsWithCause(() -> startGrid(1), IgniteCheckedException.class);
+
+        assertTrue(walModeErrorLsnr.check());


I propose getting rid of LogListener and simply checking the error message, for example:

String errMsg = GridTestUtils.assertThrowsWithCause(() -> startGrid(1), IgniteCheckedException.class) .getCause().getMessage(); assertTrue(errMsg.startsWith("Remote node has WAL mode different from local") && errMsg.contains("locWalMode=FSYNC") && errMsg.contains("rmtWalMode=LOG_ONLY"));

wernerdv · 2026-01-19T12:31:01Z

...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java

+        DataStorageConfiguration dsCfg = ctx.config().getDataStorageConfiguration();
+
+        if (dsCfg != null)
+            ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode());


Suggested change

ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode());

ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode().ordinal());

wernerdv · 2026-01-19T12:41:01Z

...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java


        Boolean locSecurityCompatibilityEnabled = locNode.attribute(ATTR_SECURITY_COMPATIBILITY_MODE);

+        WALMode locWalMode = locNode.attribute(ATTR_WAL_MODE);


Suggested change

WALMode locWalMode = locNode.attribute(ATTR_WAL_MODE);

WALMode locWalMode = locNode.attribute(ATTR_WAL_MODE) == null ? null : WALMode.fromOrdinal(locNode.attribute(ATTR_WAL_MODE));

wernerdv · 2026-01-19T12:41:37Z

...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java

                }
            }
+
+            WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);


Suggested change

WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);

WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE) == null ? null : WALMode.fromOrdinal(n.attribute(ATTR_WAL_MODE));

wernerdv · 2026-01-19T12:42:01Z

...s/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java

+
+            WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);
+
+            if (locWalMode != rmtWalMode) {


Suggested change

if (locWalMode != rmtWalMode) {

if (!Objects.equals(locWalMode, rmtWalMode)) {

nizhikov · 2026-01-23T09:02:53Z

modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java

+        DataStorageConfiguration dsCfg = cfg.getDataStorageConfiguration();
+
+        ctx.addNodeAttribute(ATTR_WAL_MODE,
+            dsCfg != null ? dsCfg.getWalMode().ordinal() : DataStorageConfiguration.DFLT_WAL_MODE.ordinal());


Why do we want to use DFLT_WAL_MODE when dsCfg is null?
We don't want to send untrue values to the other nodes.
Let's use null value if possible or don't set WAL attribute if dsCfg is null and handle it on receiver side.

nizhikov · 2026-01-23T09:06:18Z

...rg/apache/ignite/internal/managers/discovery/GridDiscoveryManagerWalModeConsistencyTest.java

+     * @throws Exception If failed.
+     */
+    @Test
+    public void testDifferentWalModesCannotJoin() throws Exception {


Let's add tests where

In memory node

Persistence + DFLT_WAL_MODE node

joins into cluster.

In memory node

Persistence + FSYNC_MODE node

joins into cluster.

nizhikov · 2026-01-23T09:07:14Z

...rg/apache/ignite/internal/managers/discovery/GridDiscoveryManagerWalModeConsistencyTest.java

+     * @throws Exception If failed.
+     */
+    @Test
+    public void testSameWalModeJoinsSuccessfully() throws Exception {


Please, add start of client node and creation of some cache to the each test.

This reverts commit c3c0c4a.

wernerdv reviewed Jan 19, 2026

View reviewed changes

wernerdv approved these changes Jan 20, 2026

View reviewed changes

wernerdv approved these changes Jan 21, 2026

View reviewed changes

DEADripER changed the title ~~Ignite 27473~~ IGNITE-27473: WALMode consistency check and tests Jan 21, 2026

nizhikov reviewed Jan 23, 2026

View reviewed changes

DEADripER added 6 commits January 23, 2026 12:42

walmode consistency check and tests

750e96f

remove persistence

7b75067

review fixes 1

c6b8d0c

review 2 fixes

420c6db

review 3 fixes

434e1ed

review 4 fixes

c3c0c4a

DEADripER force-pushed the IGNITE-27473 branch from 7877c05 to c3c0c4a Compare January 23, 2026 09:43

DEADripER added 4 commits January 23, 2026 15:45

Revert "review 4 fixes"

b1af003

This reverts commit c3c0c4a.

new tests

63b4497

checkstyle

5341ece

null checks and some fixes

e1af974

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-27473: WALMode consistency check and tests#12642

IGNITE-27473: WALMode consistency check and tests#12642
DEADripER wants to merge 10 commits intoapache:masterfrom
DEADripER:IGNITE-27473

DEADripER commented Jan 19, 2026

Uh oh!

wernerdv Jan 19, 2026

Uh oh!

wernerdv Jan 20, 2026 •

edited

Loading

Uh oh!

wernerdv Jan 19, 2026 •

edited

Loading

Uh oh!

wernerdv Jan 19, 2026

Uh oh!

wernerdv Jan 19, 2026

Uh oh!

wernerdv Jan 19, 2026

Uh oh!

wernerdv Jan 19, 2026

Uh oh!

nizhikov Jan 23, 2026

Uh oh!

nizhikov Jan 23, 2026

Uh oh!

nizhikov Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		DataStorageConfiguration dsCfg = ctx.config().getDataStorageConfiguration();

		if (dsCfg != null)


		GridTestUtils.assertThrowsWithCause(() -> startGrid(1), IgniteCheckedException.class);

		assertTrue(walModeErrorLsnr.check());

	ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode());
	ctx.addNodeAttribute(ATTR_WAL_MODE, dsCfg.getWalMode().ordinal());


		Boolean locSecurityCompatibilityEnabled = locNode.attribute(ATTR_SECURITY_COMPATIBILITY_MODE);

		WALMode locWalMode = locNode.attribute(ATTR_WAL_MODE);

	WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);
	WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE) == null ? null : WALMode.fromOrdinal(n.attribute(ATTR_WAL_MODE));


		WALMode rmtWalMode = n.attribute(ATTR_WAL_MODE);

		if (locWalMode != rmtWalMode) {

	if (locWalMode != rmtWalMode) {
	if (!Objects.equals(locWalMode, rmtWalMode)) {

Conversation

DEADripER commented Jan 19, 2026

The Contribution Checklist

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wernerdv Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wernerdv Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wernerdv Jan 20, 2026 •

edited

Loading

wernerdv Jan 19, 2026 •

edited

Loading