Core: Adding additional information in RestException #14927
+107
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Dec 24, 2025
geruh
reviewed
Dec 28, 2025
| case 409: | ||
| throw new AlreadyExistsException("%s", error.message()); | ||
| case 422: | ||
| throw new RESTException("Unable to process: %s", error.message()); |
Contributor
There was a problem hiding this comment.
The namespace handler had a inconsistency in the 422 case, maybe we can remove this to fall back to the new behavior in DefaultErrorHandler?
| .withMessage("Invalid input") | ||
| .build(); | ||
|
|
||
| assertThatThrownBy(() -> ErrorHandlers.defaultErrorHandler().accept(error)) |
Contributor
There was a problem hiding this comment.
Can we add some tests with out the message and type as they're optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where there are
RESTExceptionissues but the message is providing value. For instance:So, the idea is to provide
codeandtypeinRESTExceptionto get more context.