HIVE-29380: Drop synthetic HiveProject and HiveFilterProjectTSTransposeRule #6241
+34
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
| RelMetadataQuery mq = join.getCluster().getMetadataQuery(); | ||
| return HiveRelOptUtil.isRewritablePKFKJoin(join, join.getLeft(), join.getRight(), mq).rewritable; | ||
| }; | ||
| return operandJ(Join.class, null, isRewritable, any()); |
Contributor
There was a problem hiding this comment.
If it's not too much of an effort, it could be good idea to not use deprecated APIs like operandJ. Although, this is not the only place where it is used, so this is not a strict requirement. I will leave it up to you.
Member
Author
There was a problem hiding this comment.
I tried getting rid of the deprecations but it requires a significant refactoring of the rule so for keeping the scope of the JIRA more focused I decided not to do it as part of this PR.
soumyakanti3578
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HiveProjectand refactor callers using itHiveFilterProjectTSTransposeRulewith appropriate instantiations ofHiveFilterProjectTransposeRuleisRewritablePKFKJoincheck fromHiveFilterProjectTransposeRule#matchesWhy are the changes needed?
HiveFilterProjectTransposeRuleto work fine with more than two operands and not strictly with joinsDoes this PR introduce any user-facing change?
No
How was this patch tested?