Skip to content

Conversation

@okumin
Copy link
Contributor

@okumin okumin commented Dec 2, 2025

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my tests at testcontainers/testcontainers-java#11254, both version 2.0.2 and 2.0.3 of testcontainers-java only support Docker Engine version 29.0.0+. This will likely affect more developers who use older versions of Docker Engine.

@okumin
Copy link
Contributor Author

okumin commented Dec 18, 2025

@linghengqian I also feel 2.0.x requires upgrading Docker in too many places right now, including our Jenkins servers. I'm finding a more reasonable approach

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approach at apache/shardingsphere#37645 is to require all developers using Docker Engine v29 to execute a bash command similar to the following, because GitHub Actions is still using Docker Engine v27. The GitHub Actions CI for Windows Server 2025 uses Rancher Desktop, which is bundled with Docker Engine v28, so this issue is not encountered. See actions/runner-images#13474 .

sudo tee /etc/docker/daemon.json <<EOF
{
  "log-driver": "local",
  "min-api-version": "1.24"
}
EOF

sudo systemctl restart docker.service

Is the Hive contribution guide still at https://cwiki.apache.org/confluence/ ? I haven't seen any related documentation for Hive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants