HIVE-27224: Enhance drop table/partition command #5851
+7,567
−4,091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests unstable
tests pending
tests failed
and removed
tests pending
tests unstable
tests failed
labels
dengzhhu653
changed the title
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
dengzhhu653
force-pushed
the
HIVE-27224
branch
from
7d039fd to
e955087
Compare
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
dengzhhu653
force-pushed
the
HIVE-27224
branch
from
e955087 to
5d082e8
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
Comment on lines
+1298
to
+1300
| String catName = table.getCat(); | ||
| String dbName = table.getDb(); | ||
| String tabName = table.getTable(); |
Contributor
There was a problem hiding this comment.
nit: Should these be normalized?
| } catch (InvalidOperationException e) { | ||
| // This means there are tables of something in the database | ||
| throw new InvalidOperationException("There are still objects in the default " + | ||
| "database for catalog " + catName); |
Contributor
There was a problem hiding this comment.
nit: should we also throw stack trace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?