Skip to content

HBASE-28601 Enable setting memstore on-heap sizes in bytes #7726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
liuxiaocs7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HBASE-28601 Enable setting memstore on-heap sizes in bytes #7726

liuxiaocs7 wants to merge 1 commit into from
+103 −32

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Feb 10, 2026

ndimiduk
ndimiduk approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java
*/
public static long getMemstoreSizeInBytes(Configuration conf) {
try {
return Long.parseLong(conf.get(MEMSTORE_MEMORY_SIZE_KEY, "-1"));
Copy link
Member

@ndimiduk ndimiduk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we support human-friendly values here?

Copy link
Contributor Author

@liuxiaocs7 liuxiaocs7 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ndimiduk, sure, we support human-friendly values, just like in blockcache, and I add some more test cases in jira, please help take a look when free, thanks!!!

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 11, 2026

Hi, @ndimiduk, in the runner summary(https://github.com/apache/hbase/actions/runs/21860359593?pr=7726), how can we see which ut failed, thanks!

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026

The failed units test should be mentioned in a table in the Summary of the run. It's kinda hard to find on the GitHub UI, and it appears to not render at all on mobile.

I'll get you a direct link when I'm back at my desk.

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026

It's this feature. https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026

I thought I had added this feature along with the unit test job, but I don't see the failed tests in the summary. For now, you'll have to download the artifact from that medium test run and look for the surefire reports there. Let me see what happened to that feature in our build.

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026

I see. I'm parsing Failures but not Errors -- i.e., unit test assertions that failed, but not uncaught thrown exceptions and the like. That's an omission.

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 11, 2026

I see. I'm parsing Failures but not Errors -- i.e., unit test assertions that failed, but not uncaught thrown exceptions and the like. That's an omission.

Hi, @ndimiduk, thank you very much for your quick response. I'm relieved we've identified the underlying issue, which explains why I could sometimes see failed UTs in the Summary and sometimes not. In any case, thank you for your efforts!!!

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 11, 2026 •
edited
Loading

For example, in this runner job summary(https://github.com/apache/hbase/actions/runs/21894809023), we can see Failed Tests in large-wave-3 summary, but nothing in failed large-wave-1 summary.

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026 •
edited
Loading

https://issues.apache.org/jira/browse/HBASE-29888
#7735

@ndimiduk
Copy link
Member

ndimiduk commented Feb 11, 2026

The summary I'm talking about is accessed from up here

image

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 11, 2026

https://issues.apache.org/jira/browse/HBASE-29888

@ndimiduk Got it, thanks Nick!

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 12, 2026

Hi, @ndimiduk, thanks for help to retrigger the ut, medium test fails seems hbase-balancer upgrade to junit5

the first three uts below fails on my local env, maybe they need to upgrade to junit5 because they extends StochasticBalancerTestBase which located in hbase-balancer module

java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.conf.Configuration.setBoolean(String, boolean)" because "org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.conf" is null

	at org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.testBalancerDecisions(TestBalancerDecision.java:60)

Module	Failed Tests
hbase-server	org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.testBalancerDecisions
hbase-server	org.apache.hadoop.hbase.master.balancer.TestBalancerRejection.testBalancerRejections
hbase-server	org.apache.hadoop.hbase.master.balancer.TestCacheAwareLoadBalancerCostFunctions.null
hbase-server	org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testAbortTrueOnError

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 12, 2026

Let's see #7744

@liuxiaocs7 liuxiaocs7 mentioned this pull request Feb 12, 2026
Open
@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 13, 2026

Let's see #7744

With #7744, medium test could pass(https://github.com/apache/hbase/actions/runs/21958775498?pr=7744)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liuxiaocs7 @ndimiduk