HBASE-29843 HBaseRPCController.setPriority(final TableName tn) is nev… #7692
+116
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@stoty Please see if this could solve Phoenix's problem? I introduced a new setPriority method and the default implementation in the interface is call setPriority(int) and then setPriority(TableName). Thanks. |
| (int) Math.min(Integer.MAX_VALUE, TimeUnit.NANOSECONDS.toMillis(timeoutNs))); | ||
| } | ||
| controller.setPriority(priority); | ||
| controller.setPriority(priority, tableName); |
Contributor
There was a problem hiding this comment.
Thank you for this change.
I think we could make this work from the Phoenix side with adding a function to https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/hadoop/hbase/ipc/controller/MetadataRpcController.java#L70
public void setPriority(int priority, final TableName tn) {
setPriority(tn);
}
Contributor
Author
There was a problem hiding this comment.
With this change in place, Phoenix does not need any change, since the default method of setPriority(int, TableName) is to call setPriority(int) and then setPriority(TableName).
Contributor
There was a problem hiding this comment.
When we call controller.setPriority(priority, tableName); on the metadataRpcController which doesn't have a setPriority(priority, tableName) method it results calling the
DelegatingHBaseRpcController's setPriority(int priority, @Nullable TableName tableName) method
It calls the delegate.setPriority(priority, tableName) ( not setPriority(int) and then setPriority(TableName) )
Where the delegate is HBaseRpcControllerImpl
So we won't call the MetadataRpcController's setPriority(TableName)
…er called on branch-3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er called on branch-3+