Skip to content

Conversation

@airajena
Copy link
Contributor

Description

This PR implements the missing Note CRUD (Create, Read, Update, Delete) functionality for SHARE_ACCOUNT and SAVINGS_TRANSACTION note types. The existing implementation had TODO placeholders that were logging errors instead of providing actual functionality.

What's Changed

NoteRepository.java

  • Added findBySavingsTransactionAndId(SavingsAccountTransaction, Long) query method
  • Added findByShareAccountAndId(ShareAccount, Long) query method
  • Added findByShareAccount(ShareAccount) for listing share account notes

NoteWritePlatformServiceJpaRepositoryImpl.java

  • Implemented createSavingsTransactionNote() method for creating notes on savings transactions
  • Implemented createShareAccountNote() method for creating notes on share accounts
  • Implemented updateSavingsTransactionNote() method
  • Implemented updateShareAccountNote() method
  • Updated getResourceUrlFromCommand() to properly detect SAVINGS_TRANSACTION type when subentityId is present alongside savingsId
  • Replaced log.error("TODO Implement getNoteForDelete for SHARE_ACCOUNT") with actual implementation
  • Replaced log.error("TODO Implement getNoteForDelete for SAVINGS_TRANSACTION") with actual implementation
  • Updated createNote() and updateNote() switch statements to handle new types
  • Removed unused @Slf4j annotation after removing TODO log statements

NoteAutoConfiguration.java

  • Added SavingsAccountTransactionRepository dependency injection
  • Added ShareAccountRepositoryWrapper dependency injection

Related Issue

Fixes part of FINERACT-2421 (Minor bug-fixes and enhancements of 1.15.0)

…SACTION types

- Add create, update and delete support for SHARE_ACCOUNT notes
- Add create, update and delete support for SAVINGS_TRANSACTION notes
- Add findBySavingsTransactionAndId and findByShareAccountAndId repository methods
- Update NoteAutoConfiguration with new repository dependencies
- Remove TODO log.error statements and implement actual functionality
@airajena airajena force-pushed the FINERACT-2421/implement-note-for-share-account-and-savings-transaction branch from b9ea170 to 3ec18d1 Compare January 17, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant