FINERACT-2421: Implement Note CRUD for SHARE_ACCOUNT and SAVINGS_TRANSACTION types #5337
+144
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the missing Note CRUD (Create, Read, Update, Delete) functionality for
SHARE_ACCOUNTandSAVINGS_TRANSACTIONnote types. The existing implementation had TODO placeholders that were logging errors instead of providing actual functionality.What's Changed
NoteRepository.java
NoteWritePlatformServiceJpaRepositoryImpl.java
SAVINGS_TRANSACTIONtype whensubentityIdis present alongsidesavingsIdlog.error("TODO Implement getNoteForDelete for SHARE_ACCOUNT")with actual implementationlog.error("TODO Implement getNoteForDelete for SAVINGS_TRANSACTION")with actual implementation@Slf4jannotation after removing TODO log statementsNoteAutoConfiguration.java
SavingsAccountTransactionRepositorydependency injectionRelated Issue
Fixes part of FINERACT-2421 (Minor bug-fixes and enhancements of 1.15.0)