FINERACT-1659: Prevent duplicate savings interest posting in same period #5328
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check to skip accounts where interest already posted for current period - Change transaction isolation to SERIALIZABLE to prevent concurrent duplicate postings - Only add accounts with new interest transactions to batch update - Remove unused variable to fix linter warning This fixes issue apache#2 from FINERACT-1659 where interest was being posted multiple times within the same posting period, causing incorrect calculations and duplicate entries.
- Change check to compare against currentDate instead of yesterday - Only skip accounts where interestPostedTillDate >= currentDate - This prevents same-day duplicates while allowing legitimate posting - Accounts with interestPostedTillDate <= yesterday will be processed correctly
|
@sidshas03 could you please add testing and do an squash and commit |
Contributor
Author
|
@fintecheando yes sir, working on that! |
galovics
requested changes
Jan 18, 2026
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
I don't see any test-case verifying the non-duplicated behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FINERACT-1659, item (1) (savings interest posted to the wrong GL accounts) is already addressed under FINERACT-2212 and was merged in GitHub PR #4455. ([GitHub]1) Item (3) (Post Interest for Savings job updating existing transactions and causing wrong balances) was handled separately under FINERACT-2258 and fixed via GitHub PR #4556. issues.apache.org This PR focuses only on item (2) and prevents duplicate interest posting within the same posting period.