FINERACT-2418: create the loan origination module #5322
+959
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budaidev
force-pushed
the
FINERACT-2418/loan-origination-module
branch
2 times, most recently
from
c13f4ca to
7f469ea
Compare
Contributor
|
Please take a look on the failing test cases! |
adamsaghy
reviewed
Jan 15, 2026
| WHERE c.code_name = 'LoanOriginatorType' AND cv.code_value = 'MERCHANT' | ||
| </sqlCheck> | ||
| </preConditions> | ||
| <sql> |
Contributor
There was a problem hiding this comment.
Use liquibase xml and that helps to avoid mysql / postgres sql discrepencies!
adamsaghy
requested changes
Jan 15, 2026
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please rework the liquibase changesets to use liquibase xml to define the changes instead of native sql
budaidev
force-pushed
the
FINERACT-2418/loan-origination-module
branch
2 times, most recently
from
a5348aa to
84ffa39
Compare
budaidev
force-pushed
the
FINERACT-2418/loan-origination-module
branch
from
42c8c77 to
3898abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.