FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) #5311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Jan 12, 2026
| if (!(o instanceof Charge other)) { | ||
| return false; | ||
| } | ||
| Charge other = (Charge) o; |
Contributor
There was a problem hiding this comment.
Rename the o argument to other, if you want to work with. Also you can change the argument type from Object to Charge.
Contributor
Author
There was a problem hiding this comment.
Putting this in draft for conflict resolution, meanwhile for this change i will reverting this logic back for now.
Contributor
Author
There was a problem hiding this comment.
Please review again reverted this part of code, will plan this change in upcoming phases of optimizations
Aman-Mittal
force-pushed
the
FINERACT-2421/maintainability-refractor-phase-5
branch
from
23db0e0 to
3da1570
Compare
…w Java 21 style (Phase 5)
Aman-Mittal
force-pushed
the
FINERACT-2421/maintainability-refractor-phase-5
branch
from
3da1570 to
c1f049c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.