FINERACT-2413: Schedule handling after re-amortization default behavior #5251
+900
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzeynalov
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
2 times, most recently
from
e568c0e to
b5c484f
Compare
Aman-Mittal
reviewed
Dec 27, 2025
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Show resolved
Hide resolved
ruzeynalov
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
b5c484f to
362ce49
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
4 times, most recently
from
79e9c40 to
ae3265d
Compare
Contributor
|
@oleksii-novikov-onix Please squash and rebase. |
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
09092fb to
b2a45d1
Compare
adamsaghy
reviewed
Jan 8, 2026
fineract-e2e-tests-runner/src/test/resources/features/LoanReAmortization.feature
Show resolved
Hide resolved
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
b2a45d1 to
83e909e
Compare
ruzeynalov
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
83e909e to
89c591b
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
2 times, most recently
from
e75b29a to
c411acb
Compare
adamsaghy
reviewed
Jan 12, 2026
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Jan 12, 2026
...oanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
9a144b3 to
ef79f05
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
ef79f05 to
3902342
Compare
…ter re-amortization default behavior
adamsaghy
reviewed
Jan 16, 2026
| } | ||
|
|
||
| final List<RepaymentPeriod> affectedPeriods = repaymentPeriods.stream()// | ||
| .filter(period -> !period.isReAmortized())// |
adamsaghy
reviewed
Jan 16, 2026
| private boolean reAgedEarlyRepaymentHolder; | ||
| @Setter | ||
| @Getter | ||
| private boolean reAmortized; |
Contributor
There was a problem hiding this comment.
Why do we need this? It should not have any effect on anything...
adamsaghy
reviewed
Jan 16, 2026
| final ProgressiveLoanInterestScheduleModel model) { | ||
| return model.repaymentPeriods().stream() // | ||
| .filter(repaymentPeriod -> !repaymentPeriod.isReAgedEarlyRepaymentHolder() | ||
| .filter(repaymentPeriod -> !repaymentPeriod.isReAgedEarlyRepaymentHolder() && !repaymentPeriod.isReAmortized() |
Contributor
There was a problem hiding this comment.
This seems wrong... reaged and reamortized periods can be overdue...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.