Skip to content

[ISSUE #3763] This value of consumerGroup is never used#20

Open
kashvi0 wants to merge 1 commit intoapache:mainfrom
kashvi0:fix-issue
Open

[ISSUE #3763] This value of consumerGroup is never used#20
kashvi0 wants to merge 1 commit intoapache:mainfrom
kashvi0:fix-issue

Conversation

@kashvi0
Copy link

@kashvi0 kashvi0 commented Apr 9, 2024

Fixes #3763

Motivation

[Enhancement] This value of consumerGroup is never used. #3763

Modifications

Replaced the unused value of consumerGroup with _

Documentation

  • Does this pull request introduce a new feature? - No
  • If yes, how is the feature documented? - Not applicable
  • If a feature is not applicable for documentation, explain why? - No new feature introduced.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia
Copy link
Member

The change looks fine. Please check CI failure.

@kashvi0
Copy link
Author

kashvi0 commented Apr 10, 2024

the errors in CI failure are:

  1. "Error: could not import github.com/.../.../..." - all of these errors are there because of "page not found". The repo might have been updated.
  2. "Error: Error return value of ... is not checked (errcheck)" - error handling is required.
  3. "Error: func ... is unused (unused)" - i can remove the unused functions or these errors can be ignored for now.
  4. "Error: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)" - we can use a key type

please let me know if i should make any further changes to the code.

@Pil0tXia
Copy link
Member

It looks like the ci error is an ongoing problem, so let's ignore it.

Kindly refer to the standard title format used in other PRs of EventMesh and add 'Fixes' keyword.

@kashvi0 kashvi0 changed the title Issue #3763 - Removed unused value of consumerGroup Merge pull request #20 from kashvi0/fix-issue - Fixes Issue #3763 Apr 10, 2024
@kashvi0
Copy link
Author

kashvi0 commented Apr 10, 2024

Made the changes.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 10, 2024

No yet, you need to link to the issue.

Standard title format: https://github.com/apache/eventmesh/pulls

@kashvi0 kashvi0 changed the title Merge pull request #20 from kashvi0/fix-issue - Fixes Issue #3763 [Issue #3763] This value of consumerGroup is never used Apr 10, 2024
@kashvi0
Copy link
Author

kashvi0 commented Apr 10, 2024

does this look fine now?

@Pil0tXia Pil0tXia changed the title [Issue #3763] This value of consumerGroup is never used [ISSUE #3763] This value of consumerGroup is never used Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] this value of consumerGroup is never used

2 participants

Comments