[ISSUE #3763] This value of consumerGroup is never used#20
Open
kashvi0 wants to merge 1 commit intoapache:mainfrom
Open
[ISSUE #3763] This value of consumerGroup is never used#20kashvi0 wants to merge 1 commit intoapache:mainfrom
kashvi0 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
The change looks fine. Please check CI failure. |
Author
|
the errors in CI failure are:
please let me know if i should make any further changes to the code. |
Member
|
It looks like the ci error is an ongoing problem, so let's ignore it. Kindly refer to the standard title format used in other PRs of EventMesh and add 'Fixes' keyword. |
Author
|
Made the changes. |
Member
|
No yet, you need to link to the issue. Standard title format: https://github.com/apache/eventmesh/pulls |
Author
|
does this look fine now? |
Pil0tXia
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3763
Motivation
[Enhancement] This value of consumerGroup is never used. #3763
Modifications
Replaced the unused value of
consumerGroupwith_Documentation